Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Curved Windows (and explore whether to also support flat as option) #216

Closed
avrignaud opened this issue Jul 19, 2018 · 8 comments
Closed
Labels
Needs Design Attention design team
Milestone

Comments

@avrignaud
Copy link

Hardware: All
Steps to Reproduce: N/A
Actual Behavior: flat window
Expected Behavior: option to enable curved window, and presumably control curvature
Recommendation: enable option to toggle between flat and curved windows, and explore whether curvature window control makes sense

From YouTube video review: https://youtu.be/YfF0R2v0kEk?t=250

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Jul 23, 2018

If curvature control makes sense, instead of a toggle we could make a slider from 0 (no curve) to the maximum curve allowed.

@nancyhang nancyhang added P2 Fix in the next development iteration v1.1 labels Jul 23, 2018
@thenadj
Copy link

thenadj commented Jul 23, 2018

Trello card created for this issue. We'll explore designs for this as part of the v1.1 work.
https://trello.com/c/IlzAFoYG/133-curved-browser-window-control

@thenadj thenadj added the Design label Jul 23, 2018
@nancyhang nancyhang added this to Unprioritized in FxR planning master Oct 12, 2018
@nancyhang nancyhang moved this from Unprioritized to To do in FxR planning master Oct 13, 2018
@avrignaud avrignaud added P1 Fix in the current development iteration Needs Design Attention design team and removed P2 Fix in the next development iteration labels Oct 16, 2018
@project-bot project-bot bot moved this from To do to Needs Design in FxR planning master Oct 16, 2018
@avrignaud avrignaud changed the title Explore enabling curvature of browser window controls Enable Curved Windows (and explore whether to also support flat as option) Oct 16, 2018
@avrignaud
Copy link
Author

Updating - based on discussion around font rendering quality and curved window edges (not being done), more explicitly asking to implement curved window support. Question is if we need design from @thenadj to:

  • control amount of curvature?
  • toggle between curved/flat windows option (or just stick with curved)
  • other design issues? Likely around interaction of resizing window, keyboard location, bookmark window location, etc.

@MortimerGoro
Copy link
Contributor

  • It might affect multiple window support or window placements designs. Does a curved design work if you don't look at it from the center? how can you move a curved window if you need to be on the center?
  • Resizing may be affected too

@thenadj
Copy link

thenadj commented Oct 25, 2018

@avrignaud What's the verdict on this? Seems like window positioning and cylindrical/curved windows don't play well together.

@larsbergstrom
Copy link

I believe that we will not be doing this for v1.1. We are working on purely flat layers for 1.1, which will enable us to experiment with / investigate for post-1.1.

@larsbergstrom larsbergstrom added v1.2 and removed P1 Fix in the current development iteration v1.1 labels Oct 30, 2018
@larsbergstrom larsbergstrom moved this from Needs Design to Backlog in FxR planning master Oct 30, 2018
@avrignaud avrignaud removed the v1.2 label Oct 30, 2018
@cvan
Copy link
Contributor

cvan commented Nov 3, 2018

a lot of folks complain about the curvature on Reddit. personally, I don't find it helps readability, but I'm also not reading comic books or Wikipedia articles for hours, so I'm probably not the best person to weigh in on this. if we do allow the option, I'd recommend it be buried as a non-default preference in the Settings.

FxR planning master automation moved this from Backlog to Done Mar 8, 2019
@philip-lamb philip-lamb added this to the v1.1.3 milestone Mar 8, 2019
@cvan
Copy link
Contributor

cvan commented Mar 9, 2019

cc @joshmarinacci: Might be nice to promote here on this Reddit thread this upcoming feature in the next release of FxR: https://www.reddit.com/r/OculusGo/comments/asegfn/oculus_browser_with_a_flat_screen_rather_than/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Attention design team
Projects
No open projects
Development

No branches or pull requests

7 participants