Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the user enable loading a custom environment from local storage. #231

Closed
bluemarvin opened this issue Jul 23, 2018 · 4 comments
Closed
Assignees
Labels
enhancement This issue is a new feature or request P0 Hotfix or blocker during release preparation
Milestone

Comments

@bluemarvin
Copy link
Contributor

This issue needs to be fixed before we ship. A back door was added so that updated environment s could be uploaded to the device and tested. Before we ship this feature needs to be explicitly turned on by the user or completely disabled.

@bluemarvin bluemarvin added enhancement This issue is a new feature or request P0 Hotfix or blocker during release preparation labels Jul 23, 2018
@nancyhang nancyhang added this to the V1.0 milestone Jul 26, 2018
@keianhzo
Copy link
Collaborator

@bluemarvin @thenadj Will this need design? I guess we want a setting so the user can explicitly enable this?

@keianhzo keianhzo self-assigned this Jul 31, 2018
@thenadj
Copy link

thenadj commented Jul 31, 2018

We're only shipping with one environment for v1 and not supporting the option to support a custom environment. This will need design post v1 once we enable custom environments which will also include other features like loading a 360 image, etc. @avrignaud If there is a feature I am not aware of that needs to get in before v1, please let me know.

@larsbergstrom larsbergstrom modified the milestone: V1.0 Aug 3, 2018
@keianhzo
Copy link
Collaborator

@thenadj This is related to #283 This option should be available in that panel

@keianhzo
Copy link
Collaborator

keianhzo commented Aug 23, 2018

Closed per #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a new feature or request P0 Hotfix or blocker during release preparation
Projects
None yet
Development

No branches or pull requests

5 participants