Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The History and Bookmarks sync switches are not updated immediately after a sync if they were changed on another device #2409

Closed
heres-maria-sv-inactive opened this issue Dec 3, 2019 · 3 comments · Fixed by #2586
Assignees
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@heres-maria-sv-inactive
Copy link

[Affected Versions]:

  • Firefox Reality version 7 RC5 (0706b65)

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1

[Prerequisites]:

  • The headset is turned on and the browser is open.
  • Make sure to be signed into the same FxA account on the VR device as well as another non-VR device and have them be synced.

[Steps to reproduce]:

  1. Open the “Manage Account” card from Settings and observe the History and Bookmarks sync settings.
  2. On the non-VR device, change the History and Bookmarks sync settings to other states.
  3. Perform a Sync on the non-VR device.
  4. Perform a Sync on the VR device and observe the History and Bookmarks sync switches.

[Expected results]:

  • The sync switches are changed to the latest set states.

[Actual results]:

  • The sync switches are not updated to the new states.

[Notes]:

  • Closing and reopening the “Manage Account” card makes the switches display the proper states.
  • Attached is a recording of the issue.
@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Normal issue Label for QA to mark normal issues logged label Dec 3, 2019
@jvonitter jvonitter added this to the #9 polish milestone Dec 4, 2019
@jvonitter
Copy link
Contributor

I think this is a limitation of the android components. @keianhzo can you confirm?

@keianhzo
Copy link
Collaborator

keianhzo commented Jan 13, 2020

@jvonitter We can do it. This is related to #2411. Both are addressed in this PR: #2586.

To sum up: We were syncing only when the user explicitly does it or after exiting the accounts dialog but this has some side effects like #2586. I've moved this to the same way as Fenix does it, we might encounter past issues like the sync status being reverted if changing it and syncing right away but this is more similar to how Fenix works and users shouldn't be syncing that much so I guess it's better to have real time sync.

@heres-maria-sv-inactive
Copy link
Author

I have verified this issue and it is no longer reproducible with the latest Firefox Reality version 8 RC1 build (7a444d0).
The buttons now first appear in the off states and change to the account states after the initial sync ends. If they are changed while the initial sync is in progress, they still change to the account states after the sync ends.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@heres-maria-sv-inactive heres-maria-sv-inactive added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants