Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crashes if the First Explainer page is dismissed by clicking outside it's borders if it was opened from "Send Tab to Device" option #2498

Closed
Softvision-RemusDranca opened this issue Dec 18, 2019 · 1 comment · Fixed by #2468
Assignees
Labels
in progress [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Notes]:

  • If the First Explainer page is triggered from "View Tabs", when clicking outside it's borders, the View Tabs and First Explainer page are overlapping and only after the "Start Browsing" button is clicked the app crashes. If the "Sign In" button is clicked the sign in process is started and the app is NOT crashed.
    Here is a screen recording with this behavior: link.

[Affected Versions]:

  • Firefox Reality version 8-33512130 (8dd6bff)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • Oculus Go - Android 7.1.2
  • HTC Vive Focus Plus - Android 7.1.2
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.
  • You are not logged into an FxA account.

[Steps to reproduce]:

  1. Click the "Hamburger" button.
  2. Click the "Send Tab to Device" option.
  3. Click outside the First Explainer page boundaries.
  4. Observe the behavior.

[Expected results]:

  • The page is dismissed.

[Actual results]:

  • The app crashes.

[Additional Notes]:

  • This issue is also reproducible with the production version of the app (v7).
  • This issue is not reproducible is dismissed if the First Explainer page is displayed after installing/updating the app.
  • Attached are crash the report, logcat and the screen recording of the issue:link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Blocker issue Label for QA to mark blocker issues logged label Dec 18, 2019
@jvonitter jvonitter added this to the #8 features milestone Dec 18, 2019
@heres-maria-sv-inactive

I have verified this issue is no longer reproducible with the latest Firefox Reality version 8-33580833 (777a0ae) build. The app no longer crashes when clicking outside the First Explainer page.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants