Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L10n] The "Reset Block Pop-ups.." string from the "Pop-up Permissions" prompt is cut off #2534

Closed
Softvision-RemusDranca opened this issue Dec 23, 2019 · 4 comments
Assignees
Labels
in progress L10n Localization [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 8-33550026 (933fcd5)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.
  • The app's language is set in "Spanish".

[Steps to reproduce]:

  1. Click the Settings button.
  2. Click the "Privacy and Security" card.
  3. Click the the "Advanced" button.
  4. Observe the string from the bottom left part of the prompt.

[Expected results]:

  • The string is correctly displayed.

[Actual results]:

  • The last word of the string is cut off.

[Additional Notes]:

  • I was only able to reproduce this issue with the "ES" locale.
  • Attached is a screenshot of the issue:
    PermissionsPromptES
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Minor issue Label for QA to mark minor issues logged label Dec 23, 2019
@jvonitter jvonitter added the L10n Localization label Jan 6, 2020
@jvonitter
Copy link
Contributor

@keianhzo can we allow wrapping to fit in this space?

@keianhzo
Copy link
Collaborator

keianhzo commented Jan 9, 2020

I've made all the settings widgets to wrap their content instead of a fixed height as descriptions are usually very variable in size and we are going to have this problem with other languages

@keianhzo keianhzo self-assigned this Jan 20, 2020
@keianhzo
Copy link
Collaborator

Already fixed by #2609

@heres-maria-sv-inactive

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 9-40240151 (7e03c94) build. The last word is no longer cut off.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress L10n Localization [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

4 participants