Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crashes if the “Send Tab to Device” option is clicked while the login process started from the same option is underway #2571

Closed
heres-maria-sv-inactive opened this issue Dec 31, 2019 · 1 comment · Fixed by #2573
Assignees
Labels
in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
Milestone

Comments

@heres-maria-sv-inactive

[Affected Versions]:

  • Firefox Reality version 8-33641447 (16c9df5)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • Oculus Go - Android 7.1.2
  • HTC Vive Focus Plus - Android 7.1.2
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is open.
  • Have a valid FxA account.
  • You are not logged into an FxA account.

[Steps to reproduce]:

  1. Click the "Send Tab to Device" option from the hamburger button menu.
  2. Click the “Sign In” button.
  3. Sign in using valid credentials.
  4. While the process of signing in is underway, click the “Send Tab to Device” button again.
  5. Click any of the two prompts that are displayed and observe the behavior.

[Expected results]:
Step 4: The “Sign in to send tabs” and the “Send tab to Device” prompts do not overlap.
Step 5: The app does not crash.

[Actual results]:
Step 4: The “Sign in to send tabs” and the “Send tab to Device” prompts are alternatively displayed.
Step 5: After interacting with the prompts, the app crashes.

[Notes]:

  • The issue is also reproducible from Tabs View.
  • While the app does not crash if the initial sign in was executed using “Sign into Account” from Settings or the “Sign In” button from the First Explainer Page, the prompts are still both displayed and the sign in is not finalized properly.
  • Attached is a recording of the issue.
@keianhzo keianhzo added this to the #8 features milestone Jan 2, 2020
@emstanley emstanley added this to To do in FxR Q1 via automation Jan 2, 2020
@emstanley emstanley moved this from To do to In progress in FxR Q1 Jan 2, 2020
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Major issue Label for QA to mark major issues logged label Jan 3, 2020
FxR Q1 automation moved this from In progress to Done Jan 8, 2020
@Softvision-RemusDranca
Copy link

I have verified this issue and is no longer reproducible with the latest Firefox Reality version 8-40081245 (34c12f5) build. Now, only the "Send Tab to Device" prompt remains displayed and the app doesn't crash.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
FxR Q1
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants