Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The close and share buttons in the tab view no longer work #2839

Closed
bluemarvin opened this issue Feb 21, 2020 · 2 comments · Fixed by #2843
Closed

The close and share buttons in the tab view no longer work #2839

bluemarvin opened this issue Feb 21, 2020 · 2 comments · Fixed by #2843
Assignees
Labels
in progress [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@bluemarvin
Copy link
Contributor

Configuration

Firefox Reality version: v9
Firefox Reality build ID: 18aba8b

Hardware: Go, G2

Steps to Reproduce

  1. Open multiple tabs.
  2. Open tab view
  3. Click the close button for one of the tabs.

Current Behavior

Tab view is closed and tab is not closed.

Expected Behavior

The tab is closed.

Notes

The share button has the same behavior. The tab view is closed and there is no attempt to share the tab.

@bluemarvin bluemarvin added this to the #9 polish milestone Feb 21, 2020
@Softvision-GeluHaiduc
Copy link

Using the latest RC build, Firefox Reality version 9 RC3 (18aba8b), I managed to reproduce this issue on all of the devices we have, Oculus Go, Quest, HTC Vive Focus, Focus Plus and Pico Neo2, both in closing the tab or sending the tab from the tab view. This bug will also block us on verifying some issues.

@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 9 RC4 (c64365e) installed on the Oculus Go, Quest, HTC Vive Focus, Focus Plus and Pico Neo2 headsets.
Now, the close and share buttons that appear on tabs while hovering them in the Tab View work as expected.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants