Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The FxA account is not connected if previously the email was added then quitting the app and entering the password after resume #2933

Closed
Softvision-RemusDranca opened this issue Mar 9, 2020 · 4 comments · Fixed by #3190
Assignees
Labels
FxA in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 9 rc8 (9350b40).

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • Pico Neo 2 - Android - 8.1.0

[Prerequisites]:

  • The headset is turned on, the browser is installed and open.
  • Have a valid FxA account.

[Steps to reproduce]:

  1. Click the "Sign Into Account" card from Settings.
  2. Insert the FxA account email and click the Continue button.
  3. Quit the app and reopen it.
  4. Insert the FxA password and click Sign in button.
  5. Observe if the account is connected.

[Expected results]:

  • The account is connected.

[Actual results]:

  • The account is not connected on the device even if the FxA page says that is connected.

[Additional Notes]:

  • On the HTC and Pico Neo2 devices, the issue is reproducible only after force stopping the app.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Mar 9, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Mar 9, 2020
@keianhzo
Copy link
Collaborator

A challenge is generated every time an authentication URL is created. Quitting the app makes the accounts service to lose track of that challenge and we get no authentication callbacks although the page is redirected to the success page. I guess we should at least get an error callback. I've asked the FxA team.

@Softvision-RemusDranca
Copy link
Author

@keianhzo I observed that even the sessions that are opened in other windows are closed when reopening the app, not just the FxA login session. Is this intendeed?

@bluemarvin
Copy link
Contributor

@keianhzo I observed that even the sessions that are opened in other windows are closed when reopening the app, not just the FxA login session. Is this intendeed?

I think this should be fixed by #3205

@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the latest Firefox Reality version 10-141130836 (d3f3c9b). The FxA login session is now dismissed after resuming the app.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1) and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FxA in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants