Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pop-up Blocking Override UI #3075

Closed
emstanley opened this issue Mar 30, 2020 · 5 comments · Fixed by #3082
Closed

Update Pop-up Blocking Override UI #3075

emstanley opened this issue Mar 30, 2020 · 5 comments · Fixed by #3082
Assignees
Labels
enhancement This issue is a new feature or request in progress Needs Design Attention design team UX Issue relates to UX
Milestone

Comments

@emstanley
Copy link

UX Trello Card: https://trello.com/c/LserbZRw/428-uis-86-pop-up-blocking-override

UIS-86_Pop_Up_Blocking_Override_008.pdf

@emstanley emstanley added enhancement This issue is a new feature or request Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX labels Mar 30, 2020
@emstanley emstanley added this to the #10 features milestone Mar 30, 2020
@emstanley emstanley changed the title Pop-up Blocking Override UI Update Pop-up Blocking Override UI Mar 30, 2020
@emstanley
Copy link
Author

@emstanley emstanley removed the Final Design Design complete. Any request for design revision must open in a new issue. label Mar 30, 2020
@emstanley
Copy link
Author

emstanley commented Mar 30, 2020

This may need more discussion at design review. This may be complete. Manuel is currently working on making the UI consistent.

@keianhzo
Copy link
Collaborator

keianhzo commented Apr 1, 2020

@thenadj We need a crossed out version of the "Popups blocked" icon to unify this with the rest of the permissions where the icons in the URL bar are crossed out when the site is blacklisted.

@keianhzo keianhzo added the Needs Design Attention design team label Apr 1, 2020
@keianhzo
Copy link
Collaborator

keianhzo commented Apr 1, 2020

Also we are already making the icon inside the popup icon fog. Maybe you are referring to the fact that the icon is blue when it is showing a notification? This is because we defined a style by which any button's icon is tinted in blue if a notification is showing on that button. Happens the same with the Tray buttons when they have notifications (ie. a New tab is opened).

@cjyjae35
Copy link

cjyjae35 commented Apr 1, 2020

@keianhzo I readdressed the color since the previous version of the document (UIS-86_007) said the click state's icon color should be Rhino (#8c898a). I wanted to prevent any confusion in the future.

I've attached the icon to the Trello card.

@keianhzo keianhzo self-assigned this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a new feature or request in progress Needs Design Attention design team UX Issue relates to UX
Projects
None yet
3 participants