Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some websites are duplicated in the ETP exception list #3133

Closed
Softvision-GeluHaiduc opened this issue Apr 8, 2020 · 4 comments · Fixed by #3286
Closed

Some websites are duplicated in the ETP exception list #3133

Softvision-GeluHaiduc opened this issue Apr 8, 2020 · 4 comments · Fixed by #3286
Assignees
Labels
[QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone

Comments

@Softvision-GeluHaiduc
Copy link

[Affected Versions]:

  • Firefox Reality version 10-140982354 (bce60f9)

[Affected Platforms]:

  • Oculus Go - Android 7.1.2
  • HTC Vive Focus Plus - Android 7.1.2
  • Pico G2 4K - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is open.
  • Make sure to have more than 8 websites in the ETP exception list.

[Steps to reproduce]:

  1. Open the "Privacy & Security" card from Settings.
  2. Click the “Exceptions” button from the "Enhanced Tracking Protection" setting.
  3. Observe the websites in the list.

[Expected results]:

  • All the websites from the ETP exception list are displayed.

[Actual results]:

  • Some of the websites are duplicated in the list.

[Notes]:

  • The issue is not reproducible if the list has fewer websites.
  • Attached a screen recording of the issue here.
  • Also attached a screenshot:
    Wed04-08-2020_11-44-55 09
@Softvision-GeluHaiduc Softvision-GeluHaiduc added regression [QA]:Minor issue Label for QA to mark minor issues logged labels Apr 8, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Apr 13, 2020
@bluemarvin bluemarvin modified the milestones: #10 features, #11 polish Apr 20, 2020
@bluemarvin
Copy link
Contributor

@keianhzo Has this been addressed by recent fixes to ETP exception list?

@keianhzo
Copy link
Collaborator

yes, that was the same issue, we were not providing stable Ids

@bluemarvin
Copy link
Contributor

Fixed by #3286

@Softvision-GeluHaiduc
Copy link
Author

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 10 RC4 (2999129) installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Now, websites are no longer duplicated in the ETP exception list.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants