Scene grabbables support #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rawnsley In case you want to test/review |
Exairnous
requested changes
May 6, 2024
There was a problem hiding this comment.
Sorry it took so long to get to this. I've left some inline comments, but I also noticed that:
- Grabbable networked-object-properties components aren't being migrated to networked-transform components.
- The rigid-body component doesn't import properly.
- And ammo shapes can't be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a grabbable component that will make that object grabbable in Hubs (Hubs-Foundation/hubs#6487). The object can be made capturable by a media frame if the media frame collision bitmask is enabled.
Ammo shape has also been deprecated (hidden) as part of this as it can be replaced by the physics shape component.
See Hubs-Foundation/blender-gltf-behavior-graph#16