Remove button for components #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tony056
commented
Jul 10, 2018
tony056
commented
- Changes:
- Added remove button to PropertyGroup.
- Added RemoveComponentCommand.
- Pushed the remove button to the right in PropertyGroup.scss
brianpeiris
reviewed
Jul 10, 2018
| export default function PropertyGroup({ name, children }) { | ||
| export default function PropertyGroup({ name, removeHandler, children }) { | ||
| const displayRemoveButton = (name, removeHandler) => { | ||
| if (name === "Node") { |
There was a problem hiding this comment.
I would add a removable property instead of basing this on name.
| undo() { | ||
| this.editor.addComponent(this.object, this.componentName); | ||
| this.object.traverse(child => { | ||
| this.editor.addHelper(child); |
There was a problem hiding this comment.
addHelper needs a selectionRoot parameter. this.object should work.
There was a problem hiding this comment.
Oh, actually, it looks like addComponent already takes care of adding helpers.
Closed
robertlong
pushed a commit
that referenced
this pull request
Aug 13, 2018
Remove button for components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.