Check validity of transform data #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
commented
Nov 17, 2020
| !isNaN(v.z) && | ||
| v.x !== null && | ||
| v.y !== null && | ||
| v.z !== null |
There was a problem hiding this comment.
TIL isNaN(null) is false. I forgot how fun this language can be...
Number.isNaN(null)
> false
Number.parseInt(null)
> NaN
typeof(null)
> "object"
typeof(NaN)
> "number"
brianpeiris
approved these changes
Dec 21, 2020
brianpeiris
added a commit
that referenced
this pull request
Dec 21, 2020
This was referenced Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the common / immediate impact of Hubs-Foundation/hubs#3355
If we are concerned about this for other networked properties, we should build validation into all of them. This only addresses
position/quaternion/scaleupdates.We should make sure this does not slow down the client.