Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta Ball Error #58

Open
benjaminleroy opened this issue Jun 26, 2019 · 2 comments
Open

Delta Ball Error #58

benjaminleroy opened this issue Jun 26, 2019 · 2 comments
Assignees
Labels

Comments

@benjaminleroy
Copy link
Collaborator

There is an error in the ggvis_delta_ball function that may affect all delta ball functions. The fed in data appears to have lat & long vectors reversed. Problematically this probably affects all associated functions.

@benjaminleroy benjaminleroy self-assigned this Sep 21, 2019
@benjaminleroy
Copy link
Collaborator Author

additionally, TCpredictionbands::delta_structure doesn't pass it's position onto interior functions

@benjaminleroy
Copy link
Collaborator Author

Also for all distance calculations that take a long time, (e.g. in dist_matrix_innersq) update to using raster::pointDistance function - it has lonlat abilities and it's way faster

sum(raster::pointDistance(path_list[[i]][,position],
                                                   path_list[[j]][,position],
                                                   lonlat = TRUE,
                                                   allpairs=FALSE)^2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant