Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo – layout.css.servo.enabled – in Waterfox #332

Closed
grahamperrin opened this issue Dec 25, 2017 · 12 comments
Closed

Stylo – layout.css.servo.enabled – in Waterfox #332

grahamperrin opened this issue Dec 25, 2017 · 12 comments

Comments

@grahamperrin
Copy link

From https://www.reddit.com/r/waterfox/comments/7jndj6/waterfox_5601_is_now_available_for_download_with/dr8fppp/:

… no Stylo? …

about:config

layout.css.servo.enabled
true

Result:

Stylo true (enabled by user)

… about:support says "false (disabled by build)". …

… I guess that it's not disabled, in that way, with the (experimental) port to FreeBSD, …

tl;dr

It seems that for (at least) Windows, Stylo is disabled at build time for Waterfox 56.0.1.


#298 (comment) draws attention to Mozilla bug 1341234 - bindgen doesn't pass CFLAGS for optional system dependencies

For what it's worth: with Stylo enabled in 56.0.1 on FreeBSD-CURRENT, I have not encountered any problem that I might attribute to the feature.

@Serkan-devel
Copy link

I can't find layout.css.servo.enabled on Waterfox 56.0.1 Debian 9 at all

@grahamperrin
Copy link
Author

You can add it, as a boolean.


For reference only, some things that I bookmarked a few weeks ago. Not intended to be comprehensive:

@grahamperrin
Copy link
Author

Cross reference: Why is stylo disabled ? : waterfox

@Serkan-devel
Copy link

I've added it as boolean and it's still disabled (due to build)

@grahamperrin
Copy link
Author

OK, I guess that Mozilla bug 1341234 makes it difficult to build Waterfox with Stylo on Linux.

@jbeich
Copy link
Contributor

jbeich commented Feb 9, 2018

Stylo from FF56 has many security issues fixed in FF57 (via fuzzing). MFSA 2017-24 only documented those that also affect non-Stylo code. During FF58-FF60 both non-Stylo (Android, ESR52 for critical) and Stylo would receive attention but after FF60 only Stylo.

@grahamperrin
Copy link
Author

https://www.reddit.com/r/waterfox/comments/81y78m/-/dv9jizp/:

(support is) planned for the next release 🙂

👍 cool

@Serkan-devel
Copy link

But when will the next release happen

@grahamperrin
Copy link
Author

@Serkan-devel please join the discussion under Waterfox's current status : waterfox

@grahamperrin
Copy link
Author

01a5bc4 noted with thanks.

@grahamperrin
Copy link
Author

With Waterfox 56.1.0, Stylo is enabled and built on all desktop platforms.

Two points:

I reckon that we can close this issue 332.


Looking ahead, beyond desktop platforms

Mozilla bug 1366049 - (stylo-android) enable Stylo for Android was

RESOLVED FIXED in Firefox 59

– and from Quantum-related #267 (comment):

… While still under research, I plan to plant base in 60 ESR for a "future" variant of the browser. …

@grahamperrin
Copy link
Author

grahamperrin commented Apr 10, 2018

Without reopening this issue (unless you'd like to, @MrAlex94):


… extension incompatibilities… should be rare

Re: #512 (fixed in the port to FreeBSD) Speed Start might be added to the shortlist.


… Waterfox, or a tab, crashing at … is probably an edge case.

#516 is another case.


From pull request #511, merged a few minutes ago:

Stylo from Firefox 56 is affected by many Web compatibility and security issues. It also crashes and degrades performance in some situations.

At https://www.reddit.com/r/waterfox/comments/7bj77g/-/dx12nol/ I have a shortlist of known cases/situations where users of Waterfox 56.1.0 have been affected. Just a shortlist; not intended to be comprehensive. Plus https://disqus.com/home/discussion/waterfox/the_waterfox_blog_waterfox_5610_release/#comment-3846181598 the question about why the feature was added/enabled; and so on.


Sorry for not testing more thoroughly!

G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants