🐞 Waterfox Issue List Tracker

[Peacock365]

Hey there!

This is a list of Waterfox bugs yet unresolved. No guarantee for completeness. Should some of them be resolved by now, feel free to inform me. I will delete the corresponding entries in this case. This issue was created in an attempt to create an overview and as a potential starting point for sorting them out.

Waterfox General

• Portable updater deleting inappropriately?
• Build Waterfox on linux with static musl libc
• Add README to Linux tarball
• ANGLE -> MoltenVK for macOS
• Checksum for file downloads
• Revert Bug 606655
• libc++ for macOS builds (https://github.com/parrotgeek1/FirefoxLegacy)
• 1405031 - Support additional click events for browserAction and pageAction
• Waterfox does not return its version when run with --version #1265
• https://bugzilla.mozilla.org/show_bug.cgi?id=1373490
• https://bugzilla.mozilla.org/show_bug.cgi?id=1419264
• https://bugzilla.mozilla.org/show_bug.cgi?id=1596894
• https://bugzilla.mozilla.org/show_bug.cgi?id=1419264
• Re-instate use of WebCompat add-on to help fix website issues, including UA!

Waterfox Classic

• Waterfox/Mac dictation bug Mac dictation program. #85
• On Linux: .config/waterfox | on linux it should be .config/waterfox #243 | https://bugzilla.mozilla.org/show_bug.cgi?id=259356
• Extensions break on path change Portable (Windows) - Extensions Break On Path Change (addonStartup.json.lz4 Problem) #329
• Program description on Windows misleading Update Program Description on Windows #387
• Spellchecking bug Spellchecking Bug/Feature request #374
• Autoshortening of hamburger menu fails | Unfixed bug in FF56. Perhaps to be fixed in Waterfox? #373
  | POSSIBLE SOLUTION: https://bugzilla.mozilla.org/show_bug.cgi?id=1415921#c0
• Use unbiased pixelrounding for borders | Use unbiased pixel rounding for borders #422
  | POSSIBLE SOLUTION: https://github.com/MoonchildProductions/Pale-Moon/commit/6d773b16968b50c848083382b03bd99727c08f41
• Some Firefox directories are still being created some firefox directories still created #405
• webRequest leak webRequest leak #414 | POSSIBLE SOLUTIONS | https://reviewboard.mozilla.org/r/237446/diff/7#index_header | https://hg.mozilla.org/mozilla-central/rev/ad061f4fec73#l2.75
• Waterfox "remembers" screensize tiling wm [Visual bug] Waterfox "remembers" screensize tiling wm #527
• Silently installed Mozilla add-ons | Silently-installed Mozilla addons #515
• Checkbox and radio pixelated when zoomed in When zoom in, checkbox and radio pixelated #433
• Mozilla has caught an Obj-C exception [NSInvalidArgumentException: -[NSImage drawInRect:]: unrecognized selector sent to instance 0x136655880]
• Plugin-container crash on macOS < 10.9
• Update H.264 profiles decoder
• 1580288 (Classic)
• 1560667 (Classic)
• 1218456 (Can be done, need time!) classilla/tenfourfox@5e0cd43#diff-f3f6fe3abe7e7f0ee20bf4addb9e6bb7
• 1575934 (Update IPC for this?)
• https://reddit.com/r/waterfox/comments/dorwpc/cannot_log_into_my_bank_account_with_new_waterfox/
• Add YouTube override
• Update NSS library to esr60 + security patches from esr68

Waterfox Current

• Separate out australis theme
• Fix loading of all NPAPI plugins

Features to keep

Issues that are planning to be deprecated by Mozilla, but will be kept by Waterfox

• https://bugzilla.mozilla.org/show_bug.cgi?id=1589607

ALREADY FIXED / NOT AN ISSUE ANYMORE:

• Global menu patch fails to merge Global menu patch fails to merge #350
• Resource leak About the leak (resource) #235
• Zoom-in and Zoom-out cursors don't display Zoom-in and Zoom-out mouse cursors don't display #347
• Native ALSA support Native ALSA support #464
• Dark theme issue with blue URL text Dark theme issue with blue url text #282
• Invisible scrollbars on macOS 10.13 High Sierra Scrollbar is invisible at some sites (macOS High Sierra) #482
• Memory issues, tabs getting delazified memory.free_dirty_pages in Waterfox 56.x #423
• Customize not working Customize not working #416
• Bookmarks followed by separators lose descriptions upon HTML import Bookmarks followed by separators lose descriptions upon HTML import #564
• Ubuntu 17.04 mozconfig redirection error ubuntu 17.04 mozconfig redirection error #227
• Global menu patch fails to merge Global menu patch fails to merge #350
• Plugin update check no longer brings up any results Plugin Check in extensions menu is non-functional #357

[laniakea64]

Don't expose navigator.AddonManager to content
-> #204

#449

[Peacock365]

@laniakea64

#449

Scratched from the list. What about the rest?

[laniakea64]

idk about all of the rest. The ones I reported are still unresolved, the resource URI leak is still unresolved, and I think most of the others are still unresolved too.

Not sure about this one though -

Ubuntu 17.04 mozconfig redirection error
-> #227

Will comment in that issue.

[MrAlex94]

Thanks for this list - it's actually quite helpful. I've started going through all the issues and patching them. If you guys can do local builds as well to test I'm not breaking anything, that would be appreciated 😄. I've been doing them myself and they're fine, but that's not too great of a test range as there are so many different configurations out in the wild.

[laniakea64]

@Peacock365 Should #534 be added to this list?

[Peacock365]

Thanks for working on the regressions, @MrAlex94

#404 doesn't seem to be fixable without major code rewrites, I have noticed. Even the current Firefox at times still has this problem.

#416 seems to be fixable via mozilla/gecko-dev@6b36043a0db3

#422 seems to be fixable via https://github.com/MoonchildProductions/Pale-Moon/commit/6d773b16968b50c848083382b03bd99727c08f41

[laniakea64]

URGENT!!!!!!! Resource leak
-> #235

Seems fixed in self build from d5c2541 👍

Zoom-in/Zoom-out mouse cursors don't display
-> #347

Fixed by d5c2541

[Peacock365]

@laniakea64

I updated the list to reflect the fixes for #235 and #347 Thanks for the update.

#464 and #282 and #482 seem fixed, too.

[grahamperrin]

Adobe Flash Player 28.0.0.126 can not present its context menu, crashes, with Waterfox 56.0.1 on Linux · Issue #335 …

I could probably add a few more – I occasionally review issues in chronological order, or least recently updated – but I'm wary of this issue becoming too long (for me) to absorb. YMMV

[grahamperrin]

… local builds as well to test I'm not breaking anything, …

Linux users: how are builds for you?

(On FreeBSD-CURRENT, an attempt to build 56.1.0_18 fails at audio/alsa-lib 1.1.2_1. I can probably might work around it reasonably easily (https://redd.it/8gk2v3), I don't know whether things will be as easy in Linux environments.)

[laniakea64]

Linux users: how are builds for you?

Working well for me.

[Peacock365]

@laniakea64

Would it be possible to create commits for the two issues I pointed to above the first @grahamperrin comment? After all, the code that fixes these is already out there (I linked to it in both cases)...

[laniakea64]

I don't have time to do more pull requests atm and I'm likely not the right person to do those anyway. #166 is Windows-specific and I only have Linux; I can't reproduce #416; and I don't understand the code related to #422 well enough.

[Peacock365]

@MrAlex94

Here is the list of known fixes again (so that it does not get buried in the thread):

#416 can be fixed via mozilla/gecko-dev@6b36043a0db3 (see also @jbeich comment in the issue)

#422 can be fixed via https://github.com/MoonchildProductions/Pale-Moon/commit/6d773b16968b50c848083382b03bd99727c08f41

#350 can be fixed via https://bazaar.launchpad.net/%7Emozillateam/firefox/firefox.trusty/view/1200/debian/patches/unity-menubar.patch

#414 can be fixed via:

• https://reviewboard.mozilla.org/r/237446/diff/7#index_header
• https://hg.mozilla.org/mozilla-central/rev/ad061f4fec73#l2.75

#515 can be fixed via:

devtools.webide.enabled - false
devtools.webide.autoinstallADBHelper - false
devtools.webide.autoinstallFxdtAdapters - false
devtools.webide.autoConnectRuntime - false

#387 and #405 seem like trivial, cosmetical fixes.

[MrAlex94]

#166 won't be fixed with just that patch. And regardless, just reverting one patch when a whole lot has changed in the Chromium IPC is such a terrible idea. I'm not sure at this stage if it's worth supporting Vista or lower, as Mozilla have made good performance and security updates due to removing legacy support for those platforms.

#350 isn't going to be merged in. Isn't Unity effectively abandoned since the release of Ubuntu 18.04 LTS?

[Peacock365]

Well, in this case I think you can close issue #166 ... I see your reasoning for this one.

With #350 I wouldn't be so sure, as two older LTS versions are still supported and as all versions prior to Ubuntu 18.04 had unity. It's up to you, but I don't really see a reason here not to merge it. Let's not forget that Ubuntu 16.04 will receive updates until 2021, so it is well worth to patch the issue for that version alone.

Anyway, I hope the rest is helpful regardless.

[grahamperrin]

-> #357

Duplicate of about:addons 'Check to see if your plugins are up to date' · Issue #336 …

[Peacock365]

I just noticed that @MrAlex94 mentioned additional bugs that he wanted to fix here:

https://blog.waterfoxproject.org/waterfox-56.0-release-download (Under "What's due in Q1 2018?")

Well, I have found a potential fix for the XML Buffer Overflow Crash (Bug 485941):
-> https://bugzilla.mozilla.org/show_bug.cgi?id=485941
-> FIX: https://bugzilla.mozilla.org/attachment.cgi?id=8901555&action=diff

Furthermore, @MrAlex94 mentioned Bug 895096 (inconsistent widths of border-collapsed table borders), for this one there are fixes as well:
-> https://bugzilla.mozilla.org/show_bug.cgi?id=895096
-> FIXES:

• https://hg.mozilla.org/mozilla-central/rev/5d6a0d528af1
• https://hg.mozilla.org/mozilla-central/rev/78e432e75482
• https://hg.mozilla.org/mozilla-central/rev/405957d41476

A font settings issue was brought up here:
-> https://www.reddit.com/r/waterfox/comments/7q50r9/it_seems_like_font_settings_are_erroneously/?st=JCQZQ5DB&sh=fb9aa53a
This thread suggested the following bug as the culprit, but this is somewhat wrong (this bug was fixed in Firefox / Waterfox 41.0):
https://bugzilla.mozilla.org/show_bug.cgi?id=789788
Instead, the culprit seems to be this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1430798
Bug 1430798 seems to be related to something being mishandled by the fix for Bug 789788 though. See Jonathan Kew's reply in Bug 1430798 for more info.

[grahamperrin]

👍

#121 (comment) drew attention to two more Mozilla bugs:

• 1241717 - Linear gradient color shifts are not as expected when opacity changes (want gradients to interpolate in non-premultiplied colors, contrary to spec)
• 1242145 - Diagonal checkerboard (CSS) rendering issue

… no fixes, though (unless I'm missing something).

[Peacock365]

@grahamperrin

You missed something.

This deals with Bug 1241717:
https://github.com/MoonchildProductions/Pale-Moon/issues/308
These commits would FIX the issue:

• https://github.com/MoonchildProductions/Pale-Moon/commit/665ce3a5f1814c98bcd05f5611d1079ab99fd5d1
• https://github.com/MoonchildProductions/Pale-Moon/commit/dab2fee747d1853d5e081f69750869d45b7cf6b0

Mr. Straver hinted...
https://bugzilla.mozilla.org/show_bug.cgi?id=1242145#c10
...to this, which would fix Bug 1242145 when applied on top of the two aforementioned FIXES:
https://bugzilla.mozilla.org/show_bug.cgi?id=1241717#c10

[MrAlex94]

So I'm focusing on getting all the security patches done, then will revisit this after.

[Peacock365]

#433 is fixed. EDIT: Fix reverted as insufficient.

[criztovyl]

Could you maybe add a checklist to the issue description? That way it might be easier to track the status how many issues are already resolved. :)
(See GitHub Help: About task lists)

[grahamperrin]

Should I begin adding other open issues?

[Peacock365]

@criztovyl

Sure, I did just set one up now.

@grahamperrin

Feel free to do so. The two criterions I used to track "real" issues down are as follows:

1. The issue is not add-on related (in which case the add-on dev would be the one to approach).
2. The issue is present on a platform Waterfox actually supports (e.g. XP/Vista problems are WONTFIX by default).

I think those two criterions make sense. I am anticipating your further entries.

[MrAlex94]

Okay have updated the list and re-organised it a bit. Shame I can't take over issues so @Peacock365 doesn't get bombarded with notifications :-)

[troysjanda]

expect a new current build soon?

[grahamperrin]

https://www.waterfox.net/blog/waterfox-2019.12-release/ coming soon

[laniakea64]

Couple things to consider adding to the list of Waterfox Current specific issues? -

1. It is still impossible to do a stock Waterfox Current build on Linux. I still use these mozconfig customisations to unbreak building - Unable to build gecko68 branch #944 (comment)

2. Quoting @Peacock365 -

security.family_safety.mode must be set to 0, in order to fend off potential issues due to local Man in the middle setups. See the Pale Moon 28.4.1 release notes, too: https://www.palemoon.org/releasenotes-archived.shtml Waterfox 56 had this set to 0 as well, as opposed to Firefox where this has been set to 2 since Firefox 52.

I'm not able to create pull requests for these issues, since:

• regarding (1), I have no way to tell whether any fix I use would be too specific to my build environment,
• regarding (2), although I do see that pref at default value of 2, I'm on Linux and that only applies to Windows.

[MrAlex94]

Couple things to consider adding to the list of Waterfox Current specific issues? -

1. It is still impossible to do a stock Waterfox Current build on Linux.  I still use these mozconfig customisations to unbreak building - [#944 (comment)](https://github.com/MrAlex94/Waterfox/issues/944#issuecomment-526942809)

2. Quoting @Peacock365 -

security.family_safety.mode must be set to 0, in order to fend off potential issues due to local Man in the middle setups. See the Pale Moon 28.4.1 release notes, too: https://www.palemoon.org/releasenotes-archived.shtml Waterfox 56 had this set to 0 as well, as opposed to Firefox where this has been set to 2 since Firefox 52.

I'm not able to create pull requests for these issues, since:

* regarding (1), I have no way to tell whether any fix I use would be too specific to my build environment,

* regarding (2), although I do see that pref at default value of `2`, I'm on Linux and that only applies to Windows.

Hmm, I can seem to build with the current .mozconfig, maybe I've got a local change or ENV variable set. I will double check

[troysjanda]

Curious, will there be a new Current build soon? Not being pushy just saw that Classic was updated but no Current build.

[MrAlex94]

This is issue has been closed and replaced with this issue, since GitHub does not allow changing ownership of issues.