Waterfox 56.2.7.1 build failure with FreeBSD-CURRENT r343931 and multimedia/libvpx 1.8.0

[grahamperrin]

www/waterfox already deprecated on FreeBSD.

The tail of a build error log:

…
In file included from /wrkdirs/usr/ports/www/waterfox/work/.build/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.cpp:20:
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:858:17: error: no member named 'frame_flags' in 'vpx_svc_ref_frame_config'
        sf_conf.frame_flags[layer_idx] = layer_flags;
        ~~~~~~~ ^
1 error generated.
gmake[4]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/rules.mk:1064: Unified_cpp_codecs_vp90.o] Error 1
gmake[4]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9'
gmake[3]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/recurse.mk:73: media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/target] Error 2
gmake[3]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[2]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/recurse.mk:33: compile] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[1]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/rules.mk:453: all] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
*** Error code 1

Stop.
make: stopped in /usr/ports/www/waterfox
=>> Cleaning up wrkdir
===>  Cleaning for waterfox-56.2.7.1
build of www/waterfox | waterfox-56.2.7.1 ended at Sat Feb  9 23:10:43 GMT 2019
build time: 02:09:25
!!! build failure encountered !!!```

At https://github.com/MrAlex94/Waterfox/find/master

• I find e.g. codecs/vp9/
• but not codecs/vp9/vp9_webrtc_vp9

Re: https://www.freshports.org/multimedia/ffmpeg/ and https://www.freshports.org/multimedia/libvpx/ I assume that failure arises from the recent update of libvpx to 1.8.0.

---

Now: using poudriere, I aim to build with inferior libvpx 1.7.0_4 (2019-01-02), so I edit the libvpx line in my

/usr/local/poudriere/ports/default/www/waterfox/Makefile

– corresponding to https://svnweb.freebsd.org/ports/head/www/waterfox/Makefile?revision=480899&view=markup&pathrev=480899#l22 – but my edits do not have the required effect. poudriere continues to use libvpx-1.8.0.

I tried e.g.:

libvpx=1.7.0_4:multimedia/libvpx \

– and

libvpx=1.7.0:multimedia/libvpx \

Anyone please, what's my mistake?

In the poudriere environment, is it wrong (or insufficient) to focus on the Makefile for Waterfox?

Notes

root@momh167-gjp4-8570p:~ # date ; uname -v
Sun Feb 10 01:33:19 GMT 2019
FreeBSD 13.0-CURRENT r343931 GENERIC-NODEBUG 
root@momh167-gjp4-8570p:~ # poudriere jail -i -j head | grep -i version
Jail version:      13.0-CURRENT 1300010
root@momh167-gjp4-8570p:~ # 

https://github.com/MrAlex94/Waterfox/blob/450c4d90a1e6e98788b999e80466e682823281d2/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#L858

https://github.com/MrAlex94/Waterfox/blob/5af00ea6a02f7f23152fcd2e1d443ab73266790c/config/rules.mk#L1064

[jbeich]

frame_flags was removed in webmproject/libvpx@a66da313805f and webrtc/webrtc@be71a1ee08c9, so drop --with-system-libvpx by adding -vpx to USE_MOZILLA in www/waterfox/Makefile. Bug 1525393 should provide a real fix.

[grahamperrin]

👍 thanks as always @jbeich

I see rust in my queue at

/usr/local/poudriere/data/logs/bulk/head-default/latest/build.html

– so it'll be a few hours before I gain the Waterfox end result. Closing now with an assumption that the result will be good.

[grahamperrin]

Note to self: via https://svnweb.freebsd.org/ports?view=revision&revision=492305 I had already glanced at https://svnweb.freebsd.org/ports/head/www/firefox-esr/Makefile?r1=492305&r2=492304&pathrev=492305 but the significance of USE_MOZILLA= had gone over my head. D'uh!

[grahamperrin]

Bloody cats. Love 'em, but Billski Squeakelstiltskin heffalumped himself across the notebook keyboard, Konsole with poudriere in front (Murphy's Law), after more than eight hours of build time. Thankfully Rust was complete, only Waterfox was interrupted:

…
[08:18:31] Logs: /usr/local/poudriere/data/logs/bulk/head-default/2019-02-10_02h07m40s
\^\[08:25:07] [01] [02:04:41] Finished www/waterfox | waterfox-56.2.7.1: Failed: build
[08:25:10] Stopping 3 builders
…

For laughs:

#0 0x0000000803893b38 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/usr/local/llvm80/lib/libLLVM-8.so+0x1a93b38)
#1 0x0000000803891f05 llvm::sys::RunSignalHandlers() (/usr/local/llvm80/lib/libLLVM-8.so+0x1a91f05)
#2 0x0000000803894258 (/usr/local/llvm80/lib/libLLVM-8.so+0x1a94258)
#3 0x0000000801c66400 (/lib/libthr.so.3+0x14400)
clang-8: error: unable to execute command: Quit (core dumped)
clang-8: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 8.0.0 (tags/RELEASE_800/rc1)
Target: x86_64-portbld-freebsd13.0
Thread model: posix
InstalledDir: /usr/local/llvm80/bin
clang-8: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
clang-8: note: diagnostic msg: 
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-8: note: diagnostic msg: /tmp/nsMaiInterfaceEditableText-2e11fa.cpp
clang-8: note: diagnostic msg: /tmp/nsMaiInterfaceEditableText-2e11fa.sh
clang-8: note: diagnostic msg: 

********************
gmake[4]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/rules.mk:1064: nsMaiInterfaceEditableText.o] Error 254
gmake[4]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build/accessible/atk'
gmake[3]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/recurse.mk:73: accessible/atk/target] Error 2
gmake[3]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[2]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/recurse.mk:33: compile] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[1]: *** [/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.7.1/config/rules.mk:453: all] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
*** Error code 1

Stop.
make: stopped in /usr/ports/www/waterfox
=>> Cleaning up wrkdir
===>  Cleaning for waterfox-56.2.7.1
build of www/waterfox | waterfox-56.2.7.1 ended at Sun Feb 10 10:32:49 GMT 2019
build time: 02:04:43
!!! build failure encountered !!!

[grahamperrin]

Done, packaged.

Below, I don't know how to identify which patch files have mismatched lines, but this can wait for another day :-)

=======================<phase: patch          >============================
===>  Patching for waterfox-56.2.7.1
===>  Applying FreeBSD patches for waterfox-56.2.7.1
No such line 7185 in input file, ignoring
No such line 326 in input file, ignoring
No such line 93 in input file, ignoring
No such line 2261 in input file, ignoring
No such line 93 in input file, ignoring
No such line 13586 in input file, ignoring
No such line 878 in input file, ignoring
No such line 1265 in input file, ignoring
No such line 237 in input file, ignoring
No such line 230 in input file, ignoring
No such line 2422 in input file, ignoring
No such line 3942 in input file, ignoring
No such line 1449 in input file, ignoring
No such line 1689 in input file, ignoring
No such line 642 in input file, ignoring
No such line 1459 in input file, ignoring
No such line 5308 in input file, ignoring
No such line 1708 in input file, ignoring
No such line 1513 in input file, ignoring
===========================================================================