Set Node minimum size based on PortGroup size #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use react-resize-observer in the port groups and notify the node about size changes. In the node set the minimum size based on the port group size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use react-resize-observer in Ports and notify the Node about size changes. In Node, set the minimum size (minWidth and minHeight css props) based on the size of Ports. Size of Ports is calculated from max(top.width, bottom.width) and max(left.height, right.height).
This way node size is still calculated based on NodeInner's size, but cannot be smaller than the minimal size specified by the ports. Also this magically solves the issue with Links getting rendered at the wrong place when PortGroup is larger than the side of the Node (as it won't be larger ever).