Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRQ] Open author+non-article URLs in a popup in the WebView #4

Open
MrDevel0per opened this issue Nov 8, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MrDevel0per
Copy link
Owner

Is your feature request related to a problem? Please describe.
Not really, but this would help with going back on WebViews - if we open another URL directly in the WebView, it's hard to go back to the article, and once we impliment saving etc. features it will be harder if we have a direct save button on a nonarticle URL.

Describe the solution you'd like
When the user clicks on an author URL or a link to a different webpage, the URL should open our WebView, but in a SwiftUI .sheet popup. This is like how Apple News does it, except they use a .fullScreenCover.

Describe alternatives you've considered
We could continue opening the URLs in the WebView - that's what we're doing right now. However, this has some drawbacks as noted above. I believe this is the best solution.

Additional context
Do we want to have the sheet go fullscreen with .fullScreenCover or do we use a .sheet only?

@MrDevel0per MrDevel0per added enhancement New feature or request good first issue Good for newcomers labels Nov 8, 2023
@MrDevel0per MrDevel0per self-assigned this Nov 8, 2023
@MrDevel0per MrDevel0per mentioned this issue Nov 9, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant