Add new domains around story and moments #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a specialized API for finding stories by their ID.
Implement a use-case of showing a singular story.
Instead of routing to the editor, go to the detailed story domain when selection events happened.
Define a new activity to host ShowStoryUseCase.
Define a specialized API for finding moments by their ID.
Implement a use-case of editing a moment–both existing and new ones.
Navigate to the moment editing domain when 'add' action is selected while showing story details.
Expect the key to be injected instead of hardcoding it to improve reusability.
Define a new activity to host EditAMomentUseCase.
Trigger an event to refresh the story detail when activity lifecycle hits onResume().
Navigate to the moment editing domain when 'item_selection' action is selected while showing story details.
MrHadiSatrio
force-pushed
the
feature/moments
branch
from
8f52bd4
to
28f42ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
Added two new domains: One to show individual stories (including their moments) and another one to edit moments.
Why was it changed
Because otherwise users won't be able to write down their thoughts and use the app as intended.
Related issues