Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video don't open #1

Closed
mickymadfree opened this issue Feb 23, 2018 · 5 comments
Closed

Video don't open #1

mickymadfree opened this issue Feb 23, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mickymadfree
Copy link

This is log: https://gist.github.com/mickymadfree/e759c3e75725f4616334e35cbeff579d
I try the various setting, but can't open the video. In the plugin https://github.com/Yoshiofthewire/CrunchyXBMC when I choose "adaptive" quality, same thing.

@MrKrabat MrKrabat self-assigned this Feb 23, 2018
@MrKrabat MrKrabat added the bug Something isn't working label Feb 23, 2018
@MrKrabat
Copy link
Owner

Hi,
i uploaded an patch, it looks like the playback fallback did not start.

When the playback fails try to wait up to 30 seconds. A new loading-circle should appear.
Additionally i noticed that it can help to change the video quality from adaptive to 1080p.

The problem is that crunchyroll deliveres invalid stream files, but hopefully one of the two playback methods I implemented should work.

@mickymadfree
Copy link
Author

Now it work, but only 1080p, no matter which quality to choose. Change quality in inputstream.adaptive has no effect. Is it crunchyroll problem? Because there is same thing https://github.com/Yoshiofthewire/CrunchyXBMC/issues/79.

@MrKrabat
Copy link
Owner

MrKrabat commented Feb 23, 2018

The settings in inputstream.adaptive will only change anything if you select adaptive as quality AND the playback with inputstream.adaptive works.

In case the fallback is used, Kodi will handle that and choose the best quality regarding to your internet connection.

If you want a lower resolution set it directly in the addon settings, then Kodi and inputstream.adaptive have no other choice than that :)

@mickymadfree
Copy link
Author

I set the quality in the addon setting (360p or 480p or 720p), but the video opens in 1080p.

@MrKrabat
Copy link
Owner

MrKrabat commented Feb 23, 2018

I see what you mean.
Crunchyroll removed the quality selection feature and are returning the adaptive-url for all quality settings.

That means it is currently impossible to set the quality for the fallback case.
But it looks like it is possible
Edit: No that does not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants