Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floating point counter #55

Merged
merged 3 commits into from Aug 17, 2021
Merged

Add floating point counter #55

merged 3 commits into from Aug 17, 2021

Conversation

MrLotU
Copy link
Collaborator

@MrLotU MrLotU commented Aug 2, 2021

Adds support for swift-metrics FloatingPointCounter (apple/swift-metrics#99)

Checklist

  • The provided tests still run.
  • I've created new tests where needed.
  • I've updated the documentation if necessary.

Description

Adds a new MetricsFloatingPointCounter type that uses a PromCounter<Double, DimensionLabels> under the hood, allowing for Double values to be stored.

@MrLotU MrLotU mentioned this pull request Aug 2, 2021
Merged
@MrLotU MrLotU requested a review from ktoso August 16, 2021 10:24
ktoso
ktoso approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excellent :-)

@ktoso ktoso merged commit 7e0cf8f into master Aug 17, 2021
@MrLotU MrLotU deleted the feature/floating-point-counter branch August 17, 2021 07:27
@MrLotU
Copy link
Collaborator Author

MrLotU commented Aug 17, 2021

Released in 1.0.0-alpha.14

@MrLotU MrLotU added this to the 1.0.0 milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrLotU @ktoso