removed env vars requirement #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r accessing project root and setup the first dummy test
MrMUsmanAli
approved these changes
Nov 16, 2021
| @@ -459,7 +471,7 @@ | |||
| "$(inherited)", | |||
| "@executable_path/Frameworks", | |||
| ); | |||
| PRODUCT_BUNDLE_IDENTIFIER = "com.loblaw.fulfillment.mobilepicker.demo-wiretapp"; | |||
| @@ -70,18 +70,6 @@ | |||
| ReferencedContainer = "container:demo.wiretapp.xcodeproj"> | |||
| </BuildableReference> | |||
| </BuildableProductRunnable> | |||
| <EnvironmentVariables> | |||
| @@ -1,10 +1,3 @@ | |||
| // | |||
There was a problem hiding this comment.
This reminds me that we'll need to setup linting
There was a problem hiding this comment.
I'll take this up today
| } | ||
|
|
||
| func getRootPath() -> String? { | ||
| let pathArray: [String] = #file.split(separator: "/") |
There was a problem hiding this comment.
I'm wondering.. does this mean the placement of this file has to always be 2 levels deep from the project root?
…ly and handles the client delegate methods in a different way
- Removed the package file membership (Wiretapp, WiretappURLProtocol, WiretappSessionError) from the UITest target - Moved conditionals to switch between Record and Mock modes into the canInit methods of the classes - Temporarily added mock_responses environment variable to direct the recorded files
- Added support custom URLSession configuration
Plugged RecordURLSession into wiretapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a way to remove the need for the source root ( #file )
added the first test for tapping the hello world and loading the data and checking for the string in the list