Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone 7 problem #17

Closed
JDiDev opened this issue Mar 21, 2017 · 14 comments
Closed

iPhone 7 problem #17

JDiDev opened this issue Mar 21, 2017 · 14 comments

Comments

@JDiDev
Copy link

JDiDev commented Mar 21, 2017

This works well on previous devices, but on iPhone 7/plus the color picker image remains unchanged. I guess it has something to do with iPhone 7 having a wider color spectrum (extended rgb) than what was before.

iphone7

@aChase55
Copy link

Seeing the same issue. I've noticed this only happens with a physical device. Color picker renders properly on iPhone 7 simulator

@sarperdag
Copy link

Having the same problem. Anyone found a solution yet?

@aChase55
Copy link

aChase55 commented May 2, 2017

@MrMatthias can you at least try to point me in the right direction with this issue? Or update the status? This is a blocker for any production iOS 10 application.

@MrMatthias
Copy link
Owner

@aChase55 @sarperdag @JDiDev Can you set the colorspace in PickerImage::createImageFromData like this and see if it fixes the problem:
let colorSpace = CGColorSpace.init(name: CGColorSpace.sRGB)!
I don't have a device to test it

@sarperdag
Copy link

already tried it and it's not working...

@aChase55
Copy link

I tried to quickload view the img variable in ColorPicker's drawRect method and got this

[Example] ImageIO: handle_error:350: zlib error
[Example] ImageIO: handle_error:350: No IDATs 

Looking into it

@aChase55
Copy link

aChase55 commented May 18, 2017

I think it might be a threading issue. The A10 processor in the iPhone7 devices could be causing a race condition when rendering ColorPickerImage

This would also explain why the issue is only occuring on physical iPhone 7 devices

@MrMatthias
Copy link
Owner

@aChase55 can you try to disable the changeSize method in PickerImage? Locking should be coordinated in the ColorPicker class which is not the case.

@aChase55
Copy link

aChase55 commented Jun 6, 2017

@MrMatthias

Made the following changes:

screen shot 2017-06-06 at 12 57 19 am

screen shot 2017-06-06 at 12 51 29 am

Still seeing the same:
screen shot 2017-06-06 at 12 55 56 am

@bworby
Copy link

bworby commented Jun 29, 2017

I just ran into this issue as well. iPhone 7 does not show the Color Picker. Did anyone find a fix for this?

@h36ahmed
Copy link

Hi all, I am running into the same issue. Did someone find a solution?

@matrejek
Copy link
Contributor

@MrMatthias - I see that it does not affect BinaryClock app - any more ideas?

@matrejek
Copy link
Contributor

For those looking for the solution - here is the working one FlorianCP@058ed68

@matrejek
Copy link
Contributor

matrejek commented Dec 9, 2017

I have ported the solution for example branch, will do for master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants