Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain formulas seem to be incorrectly set up during character import #490

Open
Visparu opened this issue Jun 7, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@Visparu
Copy link

Visparu commented Jun 7, 2024

Describe the bug
Since upgrading to Foundry V12, When importing a character, the following warning(s) appear when reloading Foundry, as well as when trying to use certain features or spells:

Unable to simplify formula for Eldritch Blast (ddbEldritBlast1I) on Humphrey "Lexi" Garagal (C7u7693NV7zN1Rdq) SyntaxError: Expected "$", "(", "{", [+\-], [0-9], [^ (){}[\]$,+\-*%/], [a-z$_], [dD], or whitespace but end of input found.

I have observed this behavior for the following features and spells:

  • Wild Shape (Not sure where the error comes from here, honestly)
  • Spiritual Weapon (Damage formula, the d in d8: floor(@item.level / 2)d8 + @mod)
  • Eldritch Blast (Damage formula, the trailing +: 1d10[force] +)

I didn't check for every spell in the book, these just happened to be attached to the characters I currently have in my world. This also happens in an entirely fresh world after munching spells, items and monsters, then creating an actor and importing the character.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new actor
  2. Import a character from DnDBeyond that has one of the affected features or spells
  3. Try to use the feature or spell, e.g. the "Damage" roll for Eldritch Blast
  4. See error (It pops up as a Foundry alert as well as in the developer console)

Expected behavior
The imported formulas for said features and spells would be imported correctly.

Screenshots
Pop-up error message:
image

Console error message:
image

Environment:

  • Browser: Firefox
  • Foundry Version: 12.327
  • 5e System Version: 3.2.0
  • Module Version: 5.2.5
  • Does this behaviour occur with other modules disabled: Yes (All other modules)

Additional context
Add any other context about the problem here.

All of that said, thank you for this module, it is truly a treat and has saved me a ton of time setting up and running my games.

@Visparu Visparu added the bug Something isn't working label Jun 7, 2024
@MrPrimate MrPrimate self-assigned this Jun 8, 2024
@MrPrimate
Copy link
Owner

I'll fix the Spiritual Weapon and Eldritch Blast issues later today, but could you provide more wild shape issue details? I don't provide any macros or features for this, it just relies on the system wildshape transformation drag/drop support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants