Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link positioning #1170

Merged
merged 1 commit into from Apr 14, 2017
Merged

Fix link positioning #1170

merged 1 commit into from Apr 14, 2017

Conversation

eKoopmans
Copy link
Contributor

  • scaleFactor (k) is now correctly applied when calculating link rectangle and textWithLink height
  • Also removed redundant declaration of jsPDFAPI.link, which was declared twice

Closes #638
Related issues/PRs: #170, #390

@eKoopmans
Copy link
Contributor Author

Here's a demo of the problem behaviour. Notice that in the first example, the link positions do not correspond with the text/rectangle locations.

Current behaviour: jsFiddle
Behaviour after PR: jsFiddle

@Flamenco
Copy link
Contributor

Flamenco commented Apr 13, 2017 •
edited

Great fiddle, and thanks for the contribution! I will try to get these in over the next few days.

@eKoopmans
Copy link
Contributor Author

Thanks!

@Flamenco Flamenco merged commit 228a534 into parallax:master Apr 14, 2017
@eKoopmans eKoopmans mentioned this pull request Sep 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flamenco Flamenco Flamenco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eKoopmans @Flamenco