Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #1

Open
remcodejongh opened this issue Feb 21, 2019 · 1 comment
Open

Code cleanup #1

remcodejongh opened this issue Feb 21, 2019 · 1 comment

Comments

@remcodejongh
Copy link

Hi there!

It is my intention to start contributing on some open source projects, but since I've not done this before and stumbled upon yours I hoped I could help you a bit 😄.

I would like to do some code cleanup and add some unit tests for your controller. I first want to do the cleanup and create a PR for that.

The cleanup is mainly about moving the MakeSpringPrettyPrintJSON to a different package, since it's no controller. I'd also like to create a separate controller for the /hello call which would mean that we can use a @RequestMapping("pledges") to clean that part a bit up as well.

Let me know!
@MrRutledge
Copy link
Owner

Hi there!

Sounds good, go for it, I appreaciate all the help I can get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrRutledge @remcodejongh