Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Option "maximum parallel downloads" #20

Closed
chill0r opened this issue Nov 17, 2014 · 6 comments
Closed

Enhancement: Option "maximum parallel downloads" #20

chill0r opened this issue Nov 17, 2014 · 6 comments

Comments

@chill0r
Copy link

chill0r commented Nov 17, 2014

It would be nice if there would be an option to change the maximum downloads.

Currently it's fixed at 3 downloads at each time.

@MrS0m30n3
Copy link
Owner

Hi,
Currently you can only change the number of downloads by editing the MAX_DOWNLOAD_THREADS variable under DownloadThread.py. I could add an option on the GUI but right now i am pretty busy with other stuff and i want to find some time to finish the code refactoring so it's gonna take a while.

@nodiscc
Copy link
Collaborator

nodiscc commented Nov 20, 2014

@MrS0m30n3 good to see you here :) An option in the config file would be great at first (for me its' at ~/.youtube-dl-gui/settings)

@MrS0m30n3
Copy link
Owner

I don't want to push any changes into the code until i finish with the refactoring.I made the mistake to refactor the whole code all at once and i am like http://s2.hubimg.com/u/8530573_f520.jpg :D
and i am afraid that if i push new code the refactored one will overwrite the new changes.

@nodiscc
Copy link
Collaborator

nodiscc commented Nov 20, 2014

No problem @MrS0m30n3 take your time, I keep an eye on this issue.
I intend to package youtube-dl-gui for debian in some time (it has already been done in a third party deb repository).

About the code, I think it already looks quite clean, but some quick comments (what functions does what, what file is what, how it is structured) in the code would certainly help. Have fun with the refactoring!

@MrS0m30n3
Copy link
Owner

@nodiscc @chill0r 0f63f95

Now you can change the number of max parallel downloads by editing the 'workers_number' option on your settings.json file (~/.config/youtubedlg/settings.json). Note that you need to restart youtubedlg for the changes to take place. Also, this option will be added on the new GUI layout (as a GUI option) so you wont have to edit the settings.json file everytime.

I will leave this issue open until i push the new GUI layout.

@thefzsalam
Copy link

Hi @MrS0m30n3 it's my pleasure to help you.
But I'm completely new to git and GitHub.
I'm still trying to figure out how things work here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants