Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier handling when sending tokens #51

Closed
S0methinguseful opened this issue Oct 28, 2021 · 2 comments · Fixed by #64
Closed

Easier handling when sending tokens #51

S0methinguseful opened this issue Oct 28, 2021 · 2 comments · Fixed by #64
Labels
annoyance Annoying behaviour, not really a bug or a bug with easy workaround

Comments

@S0methinguseful
Copy link

As a user, when I send tokens, I need the application to automatically enter the minimum ERG required to send a token, in order to simplify the process. If required I can amend the ERG that is sent.

tokens
@MrStahlfelge
Copy link
Member

Good idea, will be added for the next version!

@MrStahlfelge MrStahlfelge added the annoyance Annoying behaviour, not really a bug or a bug with easy workaround label Oct 28, 2021
@MrStahlfelge
Copy link
Member

MrStahlfelge commented Dec 2, 2021 •
edited

This will be done slightly different:

  • When a token is added, the amount field stays empty, but if it is not filled by the user, it does not raise a warning but instead minimum amount is used

Also subject to change when this is done:

  • When a unique token is added (no decimals and available amount 1), the amount is automatically set to 1 and can't be changed. When remove is clicked for such a token, the amount is not emptied but the token is removed. This saves some taps when handling NFT
  • When a token is added and the amount is not set, the amount field gains focus automatically
  • When the full amount is entered, button to use the full amount should be hidden and get visibile again when amount is changed
  • Choose token to send: show tokenId

@MrStahlfelge MrStahlfelge changed the title Enable autosend of minimum ERG when sending tokens Easier handling when sending tokens Dec 2, 2021
MrStahlfelge added a commit that referenced this issue Dec 9, 2021
@MrStahlfelge
Use min amount automatically when tokens are sent #51
405eaa8
MrStahlfelge added a commit that referenced this issue Dec 10, 2021
@MrStahlfelge
When NFT is sent, the amount is automatically set to 1 and can't be …
55cc36b 
…changed #51
MrStahlfelge added a commit that referenced this issue Dec 10, 2021
@MrStahlfelge
iOS Fix distored layout for singular tokens #51
0e7cb92
MrStahlfelge added a commit that referenced this issue Dec 12, 2021
@MrStahlfelge
Add token id to Wallet details screen and Choose token to send list #51
e9153ee
MrStahlfelge added a commit that referenced this issue Dec 12, 2021
@MrStahlfelge
When a token is added, amount field gains focus when applicable. Als…
0dbf43d 
…o hide set full amount button when not applicable #51
@MrStahlfelge MrStahlfelge mentioned this issue Dec 12, 2021
Merged
@MrStahlfelge MrStahlfelge mentioned this issue Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
annoyance Annoying behaviour, not really a bug or a bug with easy workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sending tokens improvements ergoplatform/ergo-wallet-app
2 participants
@MrStahlfelge @S0methinguseful