Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 02.PPO.ipynb #22

Merged
merged 1 commit into from Apr 13, 2020
Merged

Update 02.PPO.ipynb #22

merged 1 commit into from Apr 13, 2020

Conversation

fbarez
Copy link
Contributor

@fbarez fbarez commented Apr 6, 2020

fixed typo

Curt-Park
Curt-Park approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@Curt-Park Curt-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Curt-Park
Copy link
Collaborator

@MrSyee Please check this and consider to add @fbarez as a contributor.

@MrSyee
Copy link
Owner

MrSyee commented Apr 13, 2020

@all-contributors add fbarez for maintainance

@allcontributors
Copy link
Contributor

@MrSyee

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 922

@MrSyee
Copy link
Owner

MrSyee commented Apr 13, 2020

OK. But all-contributors module has a tiny problem... So I'll add @fbarez as a contributor soon after merge this PR.

@MrSyee MrSyee merged commit 0cdbae6 into MrSyee:master Apr 13, 2020
@fbarez fbarez deleted the patch-1 branch April 13, 2020 07:32
@fbarez
Copy link
Contributor Author

fbarez commented Apr 13, 2020

Thanks @MrSyee.

@MrSyee
Copy link
Owner

MrSyee commented Apr 26, 2020

@all-contributors add @fbarez for maintenance

@allcontributors allcontributors bot mentioned this pull request Apr 26, 2020
Merged
@allcontributors
Copy link
Contributor

@MrSyee

I've put up a pull request to add @fbarez! 🎉

Repository owner deleted a comment from allcontributors bot Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Curt-Park Curt-Park Curt-Park approved these changes

@mclearning2 mclearning2 Awaiting requested review from mclearning2

@MrSyee MrSyee Awaiting requested review from MrSyee

Assignees

@MrSyee MrSyee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbarez @Curt-Park @MrSyee