Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Security Vulnerability with PacketHandler and ICustomTilePacket #37

Open
TT702 opened this issue Feb 27, 2020 · 0 comments
Open

Comments

@TT702
Copy link

TT702 commented Feb 27, 2020

Recently some of the Minecraft Server has found that the player using a modified mod to send the modified (unexpected) packet as 'ProjectRed' mod's packet to get any item they want without any permission.

handleTilePacket(sender.getEntityWorld, packet, packet.readPos())

For Example:
"The player could send the modified packet with any item they want inside to the server, at the server-side will directly set the contains item of the block without any check (e.g Barrel Block in ProjectRed - Exploration)."
https://github.com/MrTJP/ProjectRed/blob/dd27e1e3f194d3bef80e33b3f9372ce66891e715/src/mrtjp/projectred/exploration/TileBarrel.scala#L79

Please have looked to see if there's any method to solve this problem due to it will cause unauthorized code execution.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant