Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iGame fails to parse tooltypes without quotes #181

Closed
TuKo1982 opened this issue Jan 16, 2023 · 5 comments
Closed

iGame fails to parse tooltypes without quotes #181

TuKo1982 opened this issue Jan 16, 2023 · 5 comments
Labels
bug investigation Needs investigation

Comments

@TuKo1982
Copy link

TuKo1982 commented Jan 16, 2023

I use custom WHDLoad scripts into game tooltypes and facing an issue where iGame is not able to parse some of them.

i.e.

  1. ExecutePostDisk=Execute S:SomeScript
    --> game does launch from WB and tooltype gets correctly read --> this is correct WHDLoad behavior
    --> game doesn't launch from iGame

  2. ExecutePostDisk="Execute S:SomeScript"
    --> game does launch from WB but tooltype gets ignored
    --> game does launch from iGame but tooltype gets ignored

Is that something that you could fix in iGame ?
Or could you point me at the right places in sources to fix it ?

@walkero-gr
Copy link
Collaborator

@TuKo1982 Sorry for my late reply. I think I know why this happens and how to solve it. My question is why do you have that script set in the games and not in the whdload scripts under S: folder? If you did that there this would be applied on all whdload games and demos. And it would work no matter where you launch them from.

@walkero-gr walkero-gr added bug investigation Needs investigation labels Jan 20, 2023
@TuKo1982
Copy link
Author

Hi !

Because I want better granularity than an overall script. On V4, we are able to zoom, enable or disable scanlines and so.

Willem did provide a pull request for a working (tested) fix for it.

walkero-gr#39

@walkero-gr
Copy link
Collaborator

@TuKo1982 Can you please confirm that this is fixed with the latest v2.2.1 release?

@TuKo1982
Copy link
Author

TuKo1982 commented Feb 1, 2023

Confirmed ! Many thanks for the quick handling of PR and release.

@walkero-gr
Copy link
Collaborator

Have fun with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug investigation Needs investigation
Projects
None yet
Development

No branches or pull requests

2 participants