Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better experience on Bedrock Edition #49

Closed
15 tasks done
Mrcomputer1 opened this issue Aug 1, 2023 · 0 comments · Fixed by #50
Closed
15 tasks done

Better experience on Bedrock Edition #49

Mrcomputer1 opened this issue Aug 1, 2023 · 0 comments · Fixed by #50
Assignees
Labels
enhancement New feature priority/medium Medium Priority

Comments

@Mrcomputer1
Copy link
Owner

Mrcomputer1 commented Aug 1, 2023

Currently, using Smiley Player Trader from Bedrock Edition via Geyser, some features don't work properly. The plugin is technically possible to use, but it is not ideal and in many cases the player will need to fallback to the /spt sub-commands in order to manage products due to the GUI requiring right-click and similar.

Note

The primary goal of the plugin remains Java Edition, Bedrock Edition is secondary to that (it is a "nice to have" feature). It may not always be possible for Bedrock Edition to have an equal or as good experience to Java Edition due to differences between the two editions.

Known issues from Bedrock Edition

  • Some click type (such as right click) do not work. (Issue Classification: Functionality Issue)
  • Error chat messages (such as out of stock) while in villager trading GUI can't be seen (Issue Classification: UX Issue)
  • Villager trading GUI doesn't update when out of stock (Issue Classification: UX Issue)
  • Stained glass panes used in /spt GUI aren't flat on Bedrock and as a result make the GUI look ugly. (Issue Classification: Cosmetic Issue)
  • Player heads used in /spt GUI are only Steve, instead of the intended icon, due to being unsupported in Bedrock Edition. (Issue Classification: Cosmetic Issue)

Planned Solutions

  • Click Types: For Bedrock Edition players, use a mix of the normal /spt GUIs and Bedrock-specific GUIs using Geyser/Floodgate's Cumulus API (custom GUIs are actually one of the very rare cool features of Bedrock edition, it will be kind of fun to try them out 😛).
  • Error Chat Messages in Villager Trading GUI: Use Geyser's Cumulus.
  • Villager Trading GUI doesn't update:
    • Investigate why this is happening
    • Resolve the issue, if possible.
  • Stained Glass Panes: Either remove the panes or use a different item instead.
  • Player Heads: Use Geyser's Cumulus or a different item.

Requirements

  • Experience for Bedrock players using Geyser should be better.
  • Experience for Java players should remain unchanged, at least unchanged under the default configuration.
  • Geyser/Floodgate should be an optional dependency (similar to how Vault is an optional dependency).
@Mrcomputer1 Mrcomputer1 added enhancement New feature priority/medium Medium Priority labels Aug 1, 2023
@Mrcomputer1 Mrcomputer1 added this to To-Do in General To-Do List via automation Aug 1, 2023
@Mrcomputer1 Mrcomputer1 self-assigned this Aug 1, 2023
General To-Do List automation moved this from To-Do to Complete Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature priority/medium Medium Priority
Projects
General To-Do List
  
Complete
Development

Successfully merging a pull request may close this issue.

1 participant