Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a tag for the upcoming release of Coq 8.13 #310

Closed
gares opened this issue Nov 24, 2020 · 9 comments
Closed

Please create a tag for the upcoming release of Coq 8.13 #310

gares opened this issue Nov 24, 2020 · 9 comments

Comments

@gares
Copy link
Contributor

gares commented Nov 24, 2020

The Coq team is planning to release Coq 8.13-beta1 on December 7, 2020
and Coq 8.13.0 on January 7, 2020.

Your project is currently scheduled for being bundled in the Windows installer.

We are currently testing commit 6ff46f8
on branch https://github.com/Mtac2/Mtac2/tree/master
but we would like to ship a released version instead (a tag in git's slang).

Could you please tag that commit, or communicate us any other tag
that works with the Coq branch v8.13 at the latest 15 days before the
date of the final release?

Thanks!
CC: coq/coq#12334

@beta-ziliani
Copy link
Member

I've just created the tag v1.4-coq8.13. Note that this tag is one commit ahead of 6ff46f8, although only for the CHANGES file. I assume I should create one too for Unicoq, with the tip of master, right @gares ?

@gares
Copy link
Contributor Author

gares commented Nov 24, 2020

Absolutely yes (I forget to open an issue I'm afraid)

@beta-ziliani
Copy link
Member

Done (it's v1.5-8.13).

@gares
Copy link
Contributor Author

gares commented Dec 20, 2020

Did you move the tag from c438b64 to master?
FYI the new value of the tag does not build with 8.13.

@beta-ziliani
Copy link
Member

ouch sorry for messing this up, I will fix it asap

@beta-ziliani
Copy link
Member

is it ok to assume than any changes coming from you guys after the creation of the tag is for 8.14?

@beta-ziliani
Copy link
Member

(I should've created a branch for 8.13, that was the main issue)

@gares
Copy link
Contributor Author

gares commented Dec 20, 2020

Yes, when we ask to tag we commit to not break things.

I should've created a branch for 8.13, that was the main issue

I guess so, the new commit is fine (on Coq's master).

But in general moving a tag is not good. If you want 8.13 to pick a different commit, please make another tag and tell us.

@beta-ziliani
Copy link
Member

We screwed up the versioning by applying patches in the different order in different branches, that's why I decided to move the tag. Now I move it again to the true position. Let me now if there are pending issues.
Sorry for the mess... 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants