Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work as expected #1

Closed
w0am1 opened this issue Aug 15, 2022 · 8 comments
Closed

Does not work as expected #1

w0am1 opened this issue Aug 15, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@w0am1
Copy link

w0am1 commented Aug 15, 2022

I tried freezing couple of features (use alternate variant of @ and &) of fira font, but in the generated ttf file both the glyps are still same as the default variant.

@MuTsunTsai
Copy link
Owner

Hello! Fira Code in particular has been quite thoroughly tested with this app as I also use it myself, so I'm sure we can figure this out. I suppose you checked ss03 and ss05, yes? Could you provide the following info:

  1. Which font file you used as base (e.g. FiraCode-Regular.ttf), and is it the latest version?
  2. Did you try reopen the generated TTF file in FontFreeze, and is it working as expected?
  3. If it's working in FontFreeze but not somewhere else, what is your environment?

@MuTsunTsai MuTsunTsai self-assigned this Aug 15, 2022
@MuTsunTsai MuTsunTsai added the bug Something isn't working label Aug 15, 2022
@w0am1
Copy link
Author

w0am1 commented Aug 15, 2022

Hello! Fira Code in particular has been quite thoroughly tested with this app as I also use it myself, so I'm sure we can figure this out. I suppose you checked ss03 and ss05, yes? Could you provide the following info:

  1. Which font file you used as base (e.g. FiraCode-Regular.ttf), and is it the latest version?
  2. Did you try reopen the generated TTF file in FontFreeze, and is it working as expected?
  3. If it's working in FontFreeze but not somewhere else, what is your environment?

Yes I have checked ss03 and ss05 and I have been using Fira Font's latest version v6.2. When I reopen the generated TTF file in fontFreeze, the preview is as expected. But when I open the same TTF file in fontforge app or use it in notepad++, then I don't see the glyphs changed.

@MuTsunTsai
Copy link
Owner

It is the correct behavior that you won't see glyph changes in FontForge because that's not how FontFreeze force activating the features (see readme for more details). I don't use Notepad++ myself, but my understanding is that it doesn't natively support coding ligatures, so the default activation method of FontFreeze won't work with it. Could you try changing the “Target feature for activation” setting to rvrn and see if it works on Notepad++? If it still doesn't, check out this instruction and see if it helps:
https://github.com/tonsky/FiraCode/wiki/Notepad-Plus-Plus-instructions

@w0am1
Copy link
Author

w0am1 commented Aug 15, 2022

Ok got it. After following the link I can see the new @ and & in notepad++. I was thinking by default on any editor this should show the alternate variant of @ and & without needing to enable ligature.

@w0am1 w0am1 closed this as completed Aug 15, 2022
@MuTsunTsai
Copy link
Owner

It works directly on Chrome, VS Code, Visual Studio, Android Studio, and PowerShell at least. Notepad++ seems to be an exception that doesn't strictly follow OpenType specifications. Maybe you can report an issue to them.

@MuTsunTsai
Copy link
Owner

Meanwhile, I can also try to implement actual glyph subsitituion (when it comes to features involving just a single character) in the next version for maximal compatibility. I've created an new issue #2 to track this.

@MuTsunTsai
Copy link
Owner

MuTsunTsai commented Aug 16, 2022

@w0am1 The new feature is now on in v1.3. I've tested with Fira Code + ss03-05, and the generated font works in Notepad++ without additional settings. If you found this app helpful, please star and spread the news to others 😁

@w0am1
Copy link
Author

w0am1 commented Aug 16, 2022

@w0am1 The new feature is now on in v1.3. I've tested with Fira Code + ss03-05, and the generated font works in Notepad++ without additional settings. If you found this app helpful, please star and spread the news to others 😁

Checked with v1.3 and it works perfectly. Thanks 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants