Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Documentation Comments #2

Merged
merged 4 commits into from Dec 8, 2021
Merged

[Feat]: Add Documentation Comments #2

merged 4 commits into from Dec 8, 2021

Conversation

Muhesh7
Copy link
Owner

@Muhesh7 Muhesh7 commented Dec 8, 2021

In This PR

  • Fixed the bug where loading Screen sometimes still keeps on loading even when the webView is loaded.
    - This is caused by an unhandled exception when the widget rebuilds itself
    Future is Completed Already
    - This is Fixed by adding a if check which checks if the future is completed already before calling the complete()
    if(!completer.isCompleted) completer.complete(true)
  • Added Dart Documentation Comments for Every files.
    - This displays the description of a class or object when user Hovers his mouse on the class/methods.
  • Updated the README.md with the newly refractor methods and Objects.

@Muhesh7 Muhesh7 requested a review from siva2204 December 8, 2021 13:08
@siva2204 siva2204 merged commit 5d60a67 into main Dec 8, 2021
@Muhesh7 Muhesh7 deleted the dev branch December 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants