Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI for /users route #99

Merged
merged 2 commits into from Dec 24, 2022
Merged

Conversation

JohnnyOhms
Copy link
Contributor

Description

I created UI for users page
styled the user page Table using Tailwind css styled approach.
its a full width responsive tailwind css table from there DOC

Checklist:

  • This pull request follow our contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (postman and swagger)
  • I have written tests for the code
  • I have updated .env.example file for new .env variables

What is current behavior?

Unstyled user page

Closes #92

What is new behavior?

Styled User page with tailwind css table

tailwind css table layout

Breaking Changes?

None

Pls review and merge, open for corrections, Branch up till date @aayushchugh

created UI for users page
styled the user page Table using Tailwind css styled approach
@tharun634 tharun634 added the enhancement New feature or request label Dec 23, 2022
@tharun634 tharun634 added this to the v1.0.0 milestone Dec 23, 2022
Copy link
Member

@aayushchugh aayushchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnnyOhms sorry but I forgot to mention before that we need light color theme so please change the theme to light. every thing else looks great

Copy link
Member

@is-it-ayush is-it-ayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Cool! Please make the corrections suggested by @aayushchugh. Thanks for contributing.

@JohnnyOhms
Copy link
Contributor Author

Thanks for the correction, working o the Light theme now @is-it-ayush @aayushchugh

@JohnnyOhms
Copy link
Contributor Author

JohnnyOhms commented Dec 23, 2022

light mode table added on the Users page, ready to be reviewed and merge. am open for corrections
@aayushchugh @is-it-ayush
Screenshot 2022-12-23 204113

Copy link
Member

@aayushchugh aayushchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR

@aayushchugh aayushchugh changed the title worked on solution of issue #92 of UI of Users page feat: UI for /users route Dec 24, 2022
@aayushchugh aayushchugh merged commit ea965d5 into MultiEmail:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] ✨ create UI for /users page
4 participants