Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a release with Qt 5.11 compatibility #2536

Closed
leo60228 opened this issue Feb 13, 2019 · 3 comments
Closed

Create a release with Qt 5.11 compatibility #2536

leo60228 opened this issue Feb 13, 2019 · 3 comments

Comments

@leo60228
Copy link

leo60228 commented Feb 13, 2019

System Information

MultiMC version: 0.6.2 / 19bb50b

Operating System: Linux (NixOS)

Summary of the issue or suggestion:

NixOS has an official package for MultiMC, but it's currently built off the first commit with Qt 5.11 compatibilty, as NixOS does not package older versions of Qt. You could possibly backport 4d68c1b to v0.6.2 and put that in a v0.6.2-qt511 tag. This may have already been done with 0.6.3, but that does not appear to be an official release.

What should happen:

The latest official release can be built for Qt 5.11 without distribution-specific packages.

Steps to reproduce the issue (Add more if needed):

  1. Build using Qt 5.11 on v0.6.2.

  2. Build fails.

  3. Update to unstable version 4d68c1b.

  4. Build succeeds.

Suspected cause:

4d68c1b is not available in an official release

Logs/Screenshots:

Unknown CMake command "qt5_use_modules"

From NixOS/nixpkgs#42387.

@peterix
Copy link
Member

peterix commented Feb 13, 2019

The current stable release is 0.6.4: https://github.com/MultiMC/MultiMC5/releases/tag/0.6.4

@leo60228
Copy link
Author

Shouldn't this be available on the website? I thought that was a beta version, based on it only being documented in the Git repo.

@peterix
Copy link
Member

peterix commented Apr 21, 2019

The answer is: no.

I will not build with Qt 5.11 - I will continue to build with 5.4 and stop shipping Qt with linux builds.

@peterix peterix closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants