Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Launch command exit code 0 (ARM64) #3043

Closed
JJTech0130 opened this issue Mar 20, 2020 · 1 comment
Closed

Pre Launch command exit code 0 (ARM64) #3043

JJTech0130 opened this issue Mar 20, 2020 · 1 comment

Comments

@JJTech0130
Copy link

System Information

MultiMC version: 0.6.9-custom (no source code changes, using custom build for ARM64 - https://github.com/JJTech0130/MultiMC5/releases/tag/build-20)

Operating System: Ubuntu with KDE ARM64

NOTE: To make multiMC use ARM64 LWJGL I made (https://github.com/JJTech0130/MultiMC-Patcher)

Summary of the issue or suggestion:

MultiMC incorrectly detects the pre launch command as exiting with error code 0.
Why does it think 0 is an error? 0 is supposed to be success.
I cant copy the command from the log (~/MultiMC/patches/runpatcher.sh 1.9.4) and it correctly patches it, and then I can remove it from the pre launch command and minecraft runs succesfully.
I even made a wrapper for it to guarantee succesfull exit code (that is why it is runpatcher.sh not patcher.sh - runpatcher.sh is just a wrapper)
Also - MutiMC incorrectly states all my java versions are 32 bit - they are not. java -version reports 64bit.

What should happen:

MultiMC should run the command and then proceed to launch minecraft.

Steps to reproduce the issue (Add more if needed):

  1. Dowload and install MultiMC from https://github.com/JJTech0130/MultiMC5 on an ARM64 OS/ build MultiMC from source on ARM64 --- I used a raspberry pi 4 with kubuntu

  2. Install MultiMC-patcher from https://github.com/JJTech0130/MultiMC-Patcher to MultiMC/patches and add ~/MultiMC/patches/patcher.sh $INST_ID as a pre launch command

  3. Launch Minecraft

Suspected cause:

It is probably something about bash/ detecting error codes on ARM64

Logs/Screenshots:

https://paste.ee/p/rEt6B

Additional Info:

I compiled MultiMC with Jenkins on Debian ARM64 on an RPi3 (It is a private server)

@JJTech0130
Copy link
Author

Apparently, you first need to make sure it is executable and second you need to close MultiMC and relaunch after setting the prelaunch command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant