-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subfont never finishes #154
Comments
Hard to know exactly what's going on without a copy of your |
@papandreou Thanks! But I'm wonder: why |
And here's the |
Thanks. No, it doesn’t need the video files, so we’re in bug territory :) |
I removed whole pages that contains video and same again. It still stuck. |
Hmm, it works for me (with node.js 12.16.1) with your command and I noticed that you have some quite heavy fonts:
All of those will be loaded into memory, so you have to make sure that you have enough and that node.js is allowed to use it. |
You mean I have to make sure that nodejs takes enough memory? My machine has 32GiB memory, I think it's ok. Is there way to specify memory related options in |
Wait, I removed whole fonts and it still stucks. Hmm. |
Wrt. allowing it to use the memory I meant something like |
From the GC message it could look like your node thinks it's only allowed to use 512 MB. |
@papandreou How long does it take to complete when you tested? And yes, it seems it's memory problem. |
|
1 minute and 30 seconds? That's weird. It's still running on my machine for a long time. |
Does |
With below command, it stuck too. node --max-old-space-size=30000 ./node_modules/subfont/lib/cli.js --root ./dist --canonical-root https://blog.ashrimp.dev/ --output ./dist-opt --inline-css --no-fallbacks --debug ./dist/**/*.html |
Okay, weird that we're getting different results. Which version of node are you on? |
I tried both |
Looks like it also works for me with node.js 16.13.0, although it takes longer:
|
Thanks for testing :) But still I don't get it... Hmmmmm. |
Are you also trying with the exact contents of |
Yes. |
I can reproduce this problem in even macOS. Hmm. |
Ok, I got it. I tested it a lot on my macOS machine and found that the
doesn't include the
In this case, the Anyway, the |
After some printf-debugging, I found that its not stuck but it takes toooooooo long to call What do you think? I'm going to analyze the |
After many, many tries, I finally profiled the Look at this:
The class DOMException {
constructor() {
const args = [];
{
let curArg = arguments[0];
if (curArg !== undefined) {
curArg = conversions["DOMString"](curArg, { context: "Failed to construct 'DOMException': parameter 1" });
} else {
curArg = "";
}
args.push(curArg);
}
{
let curArg = arguments[1];
if (curArg !== undefined) {
curArg = conversions["DOMString"](curArg, { context: "Failed to construct 'DOMException': parameter 2" });
} else {
curArg = "Error";
}
args.push(curArg);
}
console.log(`DOMException constructor args: ${args}`);``
return iface.setup(Object.create(new.target.prototype), globalObject, args);
} And here's the output:
What is it? It tries to select pseudo-class |
Ah, wow, nice work! |
Ok, I ended this with enabling purge option in the |
I'm sure we can figure that out together! |
I found that I don't need to handle backslash escapes for now. There's no class names includes Thanks for your hark work @papandreou. |
You're welcome, happy that you found a way to avoid it. If you feel that there's a bug in |
Hello! Suddenly the
subfont
is stuck atpopulate
.And it never finishes without any additional output. What things should I check? Thank you!
EDIT
After long waiting, below is printed.
The text was updated successfully, but these errors were encountered: