Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rip cpu with that #1

Closed
ghost opened this issue Jul 9, 2019 · 9 comments
Closed

rip cpu with that #1

ghost opened this issue Jul 9, 2019 · 9 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ghost
Copy link

ghost commented Jul 9, 2019

i have a bigger suggestion if you want a good generation. Actually DaPorkchop from Nukkit already do a good job by creating new noise what is faster then Glowstone one, you can check:

https://github.com/PorkStudios/PorkLib

@Muqsit
Copy link
Owner

Muqsit commented Jul 10, 2019

Yup, the generator isn't that fast. I'm considering implementing everything before doing any optimizations whatsoever.

@Muqsit Muqsit added the enhancement New feature or request label Jul 10, 2019
@ghost
Copy link
Author

ghost commented Jul 10, 2019

image

You kinda need to remove populators from pmmp

@Muqsit
Copy link
Owner

Muqsit commented Jul 10, 2019

Oh those aren't pocketmine's populators, they are GlowstoneMC's Lake object. I most likely didn't port it correctly.

@Muqsit
Copy link
Owner

Muqsit commented Jul 17, 2019

The floating lake issue has been fixed in e819287

@ghost
Copy link
Author

ghost commented Jul 17, 2019

@Muqsit What about using taylor series instead of trigonometric and exponential functions? I think will be faster.

@ghost

This comment has been minimized.

@ghost

This comment has been minimized.

This was referenced Apr 26, 2020
@ZloyNick

This comment has been minimized.

Repository owner locked as off-topic and limited conversation to collaborators May 19, 2020
@Muqsit Muqsit added the wontfix This will not be worked on label Jun 16, 2023
@Muqsit
Copy link
Owner

Muqsit commented Jun 16, 2023

There are not many avenues for optimization in this plugin. The performance is much better since PHP 8.1 (and JIT). If you are looking for a more performant alternative, NetherGames maintains a version of this repository rewritten in C++ that may be of your interest: https://github.com/NetherGamesMC/ext-vanillagenerator.

@Muqsit Muqsit closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants