Added defensive code to prevent errors when emojis state is empty.

xfelipem · Jul 18, 2019 · a34ed3f · a34ed3f
1 parent e5842a2
commit a34ed3f
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/example/RandomEmoji/index.js b/example/RandomEmoji/index.js
@@ -8,6 +8,7 @@ import withTimer from '../../src/withTimer';
 // CONSTANTS
 const API_URL = 'https://api.github.com/emojis';
 const DEFAULT_INTERVAL = 1000;
+const EMPTY_STRING = '';
 
 // HELPERS
 
@@ -24,9 +25,12 @@ const isObjectEmpty = object => Object.entries(object).length === 0;
  * @param {Object} emojis map of emojis links sorted by name.
  */
 const selectRandomEmoji = (emojis) => {
-  if(emojis.length)
   const names = Object.keys(emojis);
 
+  if (names.length < 1) {
+    return EMPTY_STRING;
+  }
+
   return emojis[names[(names.length * Math.random()) << 0]];
 };
 
@@ -37,7 +41,7 @@ const RandomEmoji = (props) => {
 
   // STATE
   const [emojis, setEmojis] = useState({});
-  const [emoji, setEmoji] = useState('');
+  const [emoji, setEmoji] = useState(EMPTY_STRING);
 
   // PRIVATE METHODS
   const mutateEmoji = () => setEmoji(selectRandomEmoji(emojis));
@@ -73,7 +77,7 @@ const RandomEmoji = (props) => {
   useEffect(fetchEmojisEffectHandler);
   useEffect(setTimerEffectHandler);
 
-  if (emoji === '') {
+  if (emoji === EMPTY_STRING) {
     return null;
   }