Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not shown, when number of images get larger #484

Closed
soenkekueper opened this issue Oct 9, 2022 · 5 comments · Fixed by #488
Closed

Images not shown, when number of images get larger #484

soenkekueper opened this issue Oct 9, 2022 · 5 comments · Fixed by #488

Comments

@soenkekueper
Copy link

What is the expected behavior?

Even when the number of items is large, the images are displayed correctly.

What is the current behavior?

When the number of images gets larger, the images are not displayed any more.
When the window size gets below a certain point, they get shown again.
On my smartphone and regular desktop pc / laptop the default resolution will cause no images to be shown.

What are the steps to reproduce?

I've checked out the git repo and changed the image count within the ngx-gallery-app pixabay.service.ts to return 180 images instead of 18. See screenshots:

gallery

gallery small

See also the forked StackBlitz example:
https://ngx-gallery-grumsj.stackblitz.io

What is the use-case or motivation for changing an existing behavior?

It's not a change of behavior, just a bugfix.

Which versions are you using for the following packages?

Angular: 14.2.4
Angular CDK: 14.2.4
Angular CLI:
Typescript: 4.7.4
Gallery: Latest git-checkout

Is there anything else we should know?

no

@MurhafSousli
Copy link
Owner

MurhafSousli commented Oct 13, 2022

Yes, it is mentioned in a note that the current version handles around 30 images max, https://github.com/MurhafSousli/ngx-gallery/wiki#note due DOM maximum width value allowed in the browser. This will be fixed with the new major version since it will be using virtual scroll mechanism

@soenkekueper
Copy link
Author

Hey,
thanks for your reply, i have missed that note, sorry for that.

Do you have any idea when the next major release will be available or do you have a simplem work around i could use?

@MurhafSousli
Copy link
Owner

Unfortunately, I don't know! I am currently working on the documentation but there is still a bug on mobile.. I will see if I can release a beta version soon.

@MurhafSousli MurhafSousli linked a pull request Oct 18, 2022 that will close this issue
@MurhafSousli
Copy link
Owner

MurhafSousli commented Oct 27, 2022

This should be fixed in v8.0.0-beta.0

Install it npm i ng-gallery@beta and npm i bezier-easing

Could you try it and give me your feedback?

Stackblitz for v8 beta

@soenkekueper
Copy link
Author

Hey,
i've just updated my app and it works great.
All images are now shown.

Thanks for your great and fast work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants