Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to add elements, like buttons to the Gallery #487

Closed
TheDelta opened this issue Oct 16, 2022 · 1 comment
Closed

I want to add elements, like buttons to the Gallery #487

TheDelta opened this issue Oct 16, 2022 · 1 comment

Comments

@TheDelta
Copy link

TheDelta commented Oct 16, 2022

What is the expected behavior?

Offer something to add elements, like buttons to the Gallery.
I thought about overriding the components but I must override two components, which will eventually break with an update.

I would love to have something similar to thumbTemplate & itemTemplate.

What is the current behavior?

Currently I must use my own fork, see commit for my workaround: TheDelta@20e63e8

What are the steps to reproduce?

N/A

What is the use-case or motivation for changing an existing behavior?

Adding custom content to the gallery.
itemTemplate is apparently no option, because it is affected by the animation and would also add fixed components too many times (depending on item count).

I use it atm, to add buttons to toggle fullscreen, pan/zoom & HQ quality.

Which versions are you using for the following packages?

Angular: 14.2
Angular CDK: 14.2
Angular CLI: 14.2
Typescript: 4.7
Gallery: 7.1.2

Is there anything else we should know?

If my solution is already okay, I would create a PR or let me know if something should be handled differently, etc.
I'm willing to offer support in case it's needed ;)

@MurhafSousli
Copy link
Owner

MurhafSousli commented Dec 22, 2023

This was already implemented in v11 using galleryBoxDef directive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants