Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL navigation going the opposite side #540

Closed
Harpush opened this issue Apr 22, 2023 · 5 comments · Fixed by #583
Closed

RTL navigation going the opposite side #540

Harpush opened this issue Apr 22, 2023 · 5 comments · Fixed by #583
Labels

Comments

@Harpush
Copy link

Harpush commented Apr 22, 2023

What is the expected behavior?

Clicking on the left arrow goes to the next image and right to the previous image (as it's Right To Left).

What is the current behavior?

The thumb images flip to RTL mode and we can navigate the images but the left arrow is for previous (going right) and the right arrow is for next (going left)

What are the steps to reproduce?

Just add RTL to any example in the gallery site. Best shown in here (Use with <gallery> Component section)

What is the use-case or motivation for changing an existing behavior?

Weird interaction with RTL mode

Which versions are you using for the following packages?

Site versions - latest I guess?

Is there anything else we should know?

@Harpush
Copy link
Author

Harpush commented Apr 25, 2023

@MurhafSousli isn't it a bug? 🤔

@MurhafSousli
Copy link
Owner

MurhafSousli commented Apr 25, 2023

@Harpush It can be if the plugin mentioned that it supports RTL websites, so I think it is considered a feature.

@Harpush
Copy link
Author

Harpush commented Apr 25, 2023

@Harpush It can be if the plugin mentioned that it supports RTL websites, so I think it is considered a feature.

I based on the issue #322 which is now closed as completed

@Harpush
Copy link
Author

Harpush commented Aug 2, 2023

Any news concerning this?

@MurhafSousli
Copy link
Owner

As a workaround, you need to set dir="ltr" on the gallery in your RTL website, or in the global CSS

gallery {
  direction: ltr;
} 

@MurhafSousli MurhafSousli linked a pull request Dec 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants