Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using NgProgressHttpModule and NgProgressRouterModule together #164

Closed
zzakir opened this issue May 10, 2018 · 5 comments
Closed

Using NgProgressHttpModule and NgProgressRouterModule together #164

zzakir opened this issue May 10, 2018 · 5 comments

Comments

@zzakir
Copy link

zzakir commented May 10, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] question

OS and Version?

macOS Sierra

Versions

4.3.0

Desired functionality

I am trying to user the NgProgressRouterModule and NgProgressHttpModule in tandem. I have a lazy loaded module, whose child route has http calls. So when I used the progress bar, it is completed as soon as the route is loaded and no progress bar is displayed for the http call. Am I doing something wrong?

@MurhafSousli
Copy link
Owner

Are you using lazy load routes? and which want starts the progress bar the http requests or the child navigation?
Can you reproduce in stackblitz?
router stackblitz, http stackblitz

@zzakir
Copy link
Author

zzakir commented May 10, 2018

Yes I am using lazy loaded routes. I believe that the child navigation starts and ends the progress bar while http progress bar is ignored.

@zzakir
Copy link
Author

zzakir commented May 10, 2018

I have reproduced it here: https://stackblitz.com/edit/ngx-progressbar-router-sv3ahh

@zzakir
Copy link
Author

zzakir commented May 11, 2018

Fixed it by using just the NgProgressRouterModule and handling the http progress bar manually in the service.

@shelbincormsquare
Copy link

@zzakir I'm facing the same issue. Can we do something at root level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants