Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 6 / RxJS 6 #274

Closed
SebastianPodgajny opened this issue May 6, 2018 · 16 comments
Closed

Support for Angular 6 / RxJS 6 #274

SebastianPodgajny opened this issue May 6, 2018 · 16 comments

Comments

@SebastianPodgajny
Copy link

SebastianPodgajny commented May 6, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] question

OS and Version?

all

Versions

Angular CLI: 6.0.0
Node: 9.11.1
OS: linux x64
Angular: 6.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, http, language-service, material, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@angular/flex-layout              6.0.0-beta.15
@ngtools/webpack                  6.0.0
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              6.1.0
typescript                        2.7.2
webpack                           4.6.0

Repro steps

ng build

The log given by the failure

image

Desired functionality

I would like to use ngx-sharebuttons with Angular 6 / RxJS 6

Mention any other details that might be useful

https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md

@MurhafSousli
Copy link
Owner

it is coming soon, but anyway, the current Angular version 6.0.0 has a bug with AOT so we don't need to rush

@SebastianPodgajny
Copy link
Author

SebastianPodgajny commented May 7, 2018

I'm using Angular 6.0 aot (rxjs-compat) without any problems, however there is bug in build-optimizer. You can disable it in angular.json

"production": {
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": true,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": false, <--------- here
              "serviceWorker": true,
              "ngswConfigPath": "src/ngsw-config.json",
              "fileReplacements": [...]
}

issue: angular/angular-cli#10655

@naveedahmed1
Copy link

@MurhafSousli any update on this?

@RicardoVaranda
Copy link

Would also love some news on this, quite annoying warning message :$

@naveedahmed1
Copy link

This change would also help in reducing the bundle sizes. In my case this is the only plugin that's dependent on rxjs-compat.

@akopachov
Copy link

+1
This is the only one plugin I'm waiting to get rid of rxjs-compat dependency

@naveedahmed1
Copy link

The upgrade process should be as simple as running below commands:

npm install -g rxjs-tslint
rxjs-5-to-6-migrate -p src/tsconfig.app.json

rxjs-tslint is a great tool from the rxjs team to automatically migrate your project which uses RxJS 5 to RxJS 6.

@belall-shaikh
Copy link

@MurhafSousli any update on this?

@eruecco87-zz
Copy link

+1 for the Angular 6 / RxJS 6 support needed.

@kevupton
Copy link

🚶 👍 📦 Please ❤️ 🥇 💃

@eruecco87-zz
Copy link

Looks like installing first rxjs-compat takes care of it.

@RicardoVaranda
Copy link

@eruecco87 This is only supposed to be a temporary fix until package owners update their applications and not a permanent solution.

@eruecco87-zz
Copy link

I know, I'm just commenting for those who need to get it working now instead of sitting by their screens waiting for the package to be updated.

@naveedahmed1
Copy link

@MurhafSousli is it published on npm? I am receiving below error:

No matching version found for ngx-sharebuttons@6.0.0

@MurhafSousli
Copy link
Owner

MurhafSousli commented Jun 18, 2018

@naveedahmed1 @ngx-share/buttons

@naveedahmed1
Copy link

Thanks everything worked perfectly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants