-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Angular 6 / RxJS 6 #274
Comments
it is coming soon, but anyway, the current Angular version 6.0.0 has a bug with AOT so we don't need to rush |
I'm using Angular 6.0 aot (rxjs-compat) without any problems, however there is bug in build-optimizer. You can disable it in angular.json
issue: angular/angular-cli#10655 |
@MurhafSousli any update on this? |
Would also love some news on this, quite annoying warning message :$ |
This change would also help in reducing the bundle sizes. In my case this is the only plugin that's dependent on rxjs-compat. |
+1 |
The upgrade process should be as simple as running below commands:
|
@MurhafSousli any update on this? |
+1 for the Angular 6 / RxJS 6 support needed. |
🚶 👍 📦 Please ❤️ 🥇 💃 |
Looks like installing first rxjs-compat takes care of it. |
@eruecco87 This is only supposed to be a temporary fix until package owners update their applications and not a permanent solution. |
I know, I'm just commenting for those who need to get it working now instead of sitting by their screens waiting for the package to be updated. |
@MurhafSousli is it published on npm? I am receiving below error:
|
@naveedahmed1 |
Thanks everything worked perfectly 👍 |
Bug Report or Feature Request (mark with an
x
)OS and Version?
all
Versions
Repro steps
ng build
The log given by the failure
Desired functionality
I would like to use ngx-sharebuttons with Angular 6 / RxJS 6
Mention any other details that might be useful
https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md
The text was updated successfully, but these errors were encountered: