-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngx-sharebuttons does not support Ivy #523
Comments
can you try with 8.0.4? and tell me if it is working or not |
had the same issue, using |
8.0.4 fixes it indeed. Using this version for now until it's fixed. Thanks for you awesome work on this nice handy package! |
@Omar-Salem @Laurent02 I tried to build the demo with v8.0.5 and it works fine! what is the ivy error that you got? |
@MurhafSousli No directive found with exportAs 'shareButton'. |
In the provided StackBlitz you can see ngcc fails. In my project however I got no errors whatsoever, the share buttons simply did not show up. Changing to 8.0.4 or disabling Ivy rendrer fixed this, so there's definitely an issue with 8.0.5 and Ivy. I haven't really looked into what that may be though. |
@Laurent02 is right. At least with Angular 10.1.1 there is an issue with version 8.0.5 that causes an error when compiling. I received this error that disappeared when I downgraded to 8.0.4
|
I am trying to get this going with angular 9 and it does not work. I get this error: Invalid constructor parameter decorator in C:/proj/123imot.bg/client/imotbg/node_modules/ngx-sharebuttons/fesm2015/ngx-sharebuttons-icons.js: |
@MurhafSousli Based on @ewwwgiddings's error log, could disabling |
Hi, any chance that there's a solution to this? Will this affect production? |
I am sorry I forgot about this issue completely! it is now fixed in v8.1.0 |
I am submitting a
Description
When using Ivy, an application no longer compiles well with ngx-sharebuttons. (Error on Stackblitz, on dev machine no warnings whatsoever, but no share buttons either. Took me a while).
What is the use-case or motivation for the new feature?
Using Ivy should be the recommended setting for any new Angular application.
Which versions are you using for the following packages?
ngx-sharebuttons: 8.0.5
Is there anything else we should know?
Check https://stackblitz.com/edit/angular-edbc2e?file=src/app/app.module.ts
I used the same Angular versions as in my project.
The text was updated successfully, but these errors were encountered: