Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 v12.0.0 says tumblr and reddit are no longer available to use with shareButton directive #641

Closed
bjornharvold opened this issue Mar 30, 2023 · 0 comments · Fixed by #643
Labels

Comments

@bjornharvold
Copy link

This is a strange one. I upgraded to 12.0.0 today and it fails with this error. When I downgrade to 11, everything works fine again. And the only ones complaining is reddit and tumblr. I use all the other ones as well and they all work fine.

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/ngx-sharebuttons

Unable to reproduce on StackBlitz.

Expected Behavior

tumblr and reddit should be recognized by the shareButton directive.

Actual Behavior

Type '"tumblr"' is not assignable to type 'shareButtonName'.
shareButton="tumblr"

Type '"reddit"' is not assignable to type 'shareButtonName'.
shareButton="reddit"

Environment

"dependencies": {
"@angular/animations": "15.2.5",
"@angular/cdk": "15.2.5",
"@angular/common": "15.2.5",
"@angular/compiler": "15.2.5",
"@angular/core": "15.2.5",
"@angular/elements": "15.2.5",
"@angular/forms": "15.2.5",
"@angular/localize": "15.2.5",
"@angular/platform-browser": "15.2.5",
"@angular/platform-browser-dynamic": "15.2.5",
"@angular/router": "15.2.5",
"@angular/service-worker": "15.2.5",
"@angular/youtube-player": "15.2.5",
"@auth0/angular-jwt": "5.1.2",
"@cloudinary/ng": "1.11.2",
"@cloudinary/url-gen": "1.9.2",
"@fortawesome/angular-fontawesome": "0.12.1",
"@fortawesome/fontawesome-pro": "6.4.0",
"@fortawesome/fontawesome-svg-core": "6.4.0",
"@fortawesome/free-brands-svg-icons": "6.4.0",
"@fortawesome/pro-light-svg-icons": "6.4.0",
"@fortawesome/pro-regular-svg-icons": "6.4.0",
"@fortawesome/pro-solid-svg-icons": "6.4.0",
"@ng-bootstrap/ng-bootstrap": "14.0.1",
"@ng-select/ng-option-highlight": "0.0.7",
"@ng-select/ng-select": "10.0.3",
"@ngneat/content-loader": "7.0.0",
"@ngneat/transloco": "4.2.6",
"@ngrx/component": "15.4.0",
"@ngrx/component-store": "15.4.0",
"@ngrx/data": "15.4.0",
"@ngrx/effects": "15.4.0",
"@ngrx/entity": "15.4.0",
"@ngrx/router-store": "15.4.0",
"@ngrx/store": "15.4.0",
"@ngrx/store-devtools": "15.4.0",
"@nrwl/angular": "15.8.9",
"@paypal/checkout-components": "5.0.208",
"@popperjs/core": "2.11.7",
"@sentry/angular-ivy": "7.45.0",
"@sentry/tracing": "7.45.0",
"@swimlane/ngx-charts": "20.1.2",
"@webcomponents/custom-elements": "1.5.1",
"angular-calendar": "0.31.0",
"angular-calendar-scheduler": "15.0.1",
"angular-oauth2-oidc": "15.0.1",
"bootstrap": "5.2.3",
"bs-stepper": "1.7.0",
"cloudinary-build-url": "0.2.4",
"compass-mixins": "0.12.12",
"cryptocurrency-icons": "0.18.1",
"date-fns": "2.29.3",
"document-register-element": "1.14.10",
"hammerjs": "2.0.8",
"immutable": "4.3.0",
"ionicons": "7.1.0",
"lodash-es": "4.17.21",
"ng-qrcode": "8.0.1",
"ng-sortgrid": "15.0.1",
"ng2-file-upload": "3.0.0",
"ngx-captcha": "13.0.0",
"ngx-color-picker": "14.0.0",
"ngx-cookie-service": "15.0.0",
"ngx-date-fns": "10.0.1",
"ngx-duration-picker": "3.3.1",
"ngx-sharebuttons": "12.0.0",
"ngx2-pipes": "13.0.0",
"npm-font-open-sans": "1.1.0",
"recaptcha-v3": "1.10.0",
"rxjs": "~7.5.0",
"tslib": "^2.3.0",
"typeface-poppins": "1.1.13",
"typeface-raleway": "1.1.13",
"typeface-roboto": "1.1.13",
"zone.js": "~0.11.4"
}

@MurhafSousli MurhafSousli linked a pull request May 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants