You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On master branch right now (167141b), the headers are not being installed correctly. I'm guessing that defaulting to setuptools instead of distutils (Lines 3-8) is somehow causing the install_headers key in cmd_options to be ignored.
This causes problems when trying to compile external libraries that depend on trep.
The text was updated successfully, but these errors were encountered:
It seems that setuptools always ignores the install_headers target when running just install. Setting the --root or --single-version-externally-managed forces setuptools to run the install_headers target. This post on the distutils mailing list helped describe this.
Forcing users to run sudo python setup.py install_headers as part of the install process would be an option around this. Alternatively, we could override the default command that setuptools uses (see this page).
Another option is to package the header files into the dist and provide a function such as trep.get_include() which can be used by extension packages. This seems to be how numpy handles it and would ensure that the headers are present independent of the installation method.
On master branch right now (167141b), the headers are not being installed correctly. I'm guessing that defaulting to
setuptools
instead ofdistutils
(Lines 3-8) is somehow causing theinstall_headers
key incmd_options
to be ignored.This causes problems when trying to compile external libraries that depend on
trep
.The text was updated successfully, but these errors were encountered: