Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trep headers not being properly installed #31

Closed
jarvisschultz opened this issue Apr 27, 2015 · 3 comments
Closed

trep headers not being properly installed #31

jarvisschultz opened this issue Apr 27, 2015 · 3 comments
Labels

Comments

@jarvisschultz
Copy link
Contributor

On master branch right now (167141b), the headers are not being installed correctly. I'm guessing that defaulting to setuptools instead of distutils (Lines 3-8) is somehow causing the install_headers key in cmd_options to be ignored.

This causes problems when trying to compile external libraries that depend on trep.

@jarvisschultz
Copy link
Contributor Author

It seems that setuptools always ignores the install_headers target when running just install. Setting the --root or --single-version-externally-managed forces setuptools to run the install_headers target. This post on the distutils mailing list helped describe this.

Forcing users to run sudo python setup.py install_headers as part of the install process would be an option around this. Alternatively, we could override the default command that setuptools uses (see this page).

@adwilson10
Copy link
Contributor

Another option is to package the header files into the dist and provide a function such as trep.get_include() which can be used by extension packages. This seems to be how numpy handles it and would ensure that the headers are present independent of the installation method.

@adwilson10 adwilson10 added the bug label Apr 28, 2015
@adwilson10
Copy link
Contributor

This should be resolved with 9f621b7. A new functiontrep.get_include() should be used when building against the trep headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants